Re: [PATCH v3 5/5] iio: add documentation for current attribute

Jonathan Cameron
2014-09-13T19:55:42Z

On 12/09/14 00:15, Jacob Pan wrote:
> Add documentation for input current raw reading and scale.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
The content is fine, but please look at how the other types are handled.
The raw attribute is described along with the units etc in it's own
section, but the _scale attribute just gets lumped in with the equivalent
for all the other channel types.

Thanks,

Jonathan
> ---
> Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index d760b02..3c76bd8 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -1028,3 +1028,11 @@ Contact: linux-iio@vger.kernel.org
> Description:
> Raw value of rotation from true/magnetic north measured with
> or without compensation from tilt sensors.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_currentX_raw
> +What: /sys/bus/iio/devices/iio:deviceX/in_currentX_scale
> +KernelVersion: 3.18
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Raw current measurement from channel X. Units after application of
> + scale and offset are milliamps.
>