public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	eparis@redhat.com, paulmck@linux.vnet.ibm.com,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	zhenglong.cai@cs2c.com.cn, khilman@linaro.org,
	ak@linux.intel.com, mcgrof@suse.com, fabf@skynet.be,
	"dhowells@redhat.com" <dhowells@redhat.com>,
	pefoley2@pefoley.com, mgorman@suse.de, biederm@xmission.com,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using
Date: Mon, 15 Sep 2014 15:55:03 +0200	[thread overview]
Message-ID: <201409151555.03997.arnd@arndb.de> (raw)
In-Reply-To: <54155B14.9060809@gmail.com>

On Sunday 14 September 2014, Chen Gang wrote:
> Hello Maintainers:
> 
> Is this patch worthy enough to be applied?
> 
> Welcome any ideas, suggestions or completions.

I find it hard to judge whether it's worth it or not. You gave one example
for a driver that needs this, but what would be your estimate on how
many other drivers have the same problem, either producing a #warning
or misbehaving if neither symbol is set?

Having all architectures consistently report the endianess would be nice,
but we have to weigh the advantages (currently broken code, potential
simplifications) against the regression risk.

	Arnd

  reply	other threads:[~2014-09-15 13:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01 15:46 [PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using Chen Gang
2014-09-01 16:08 ` Paul Gortmaker
2014-09-01 17:01   ` H. Peter Anvin
2014-09-02  1:44     ` Chen Gang
2014-09-02  5:17     ` Paul Gortmaker
2014-09-02  6:13       ` Chen Gang
2014-09-03 11:47         ` Chen Gang
2014-09-14  9:08           ` Chen Gang
2014-09-15 13:55             ` Arnd Bergmann [this message]
2014-09-15 22:41               ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201409151555.03997.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=biederm@xmission.com \
    --cc=dhowells@redhat.com \
    --cc=eparis@redhat.com \
    --cc=fabf@skynet.be \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.de \
    --cc=khilman@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@suse.com \
    --cc=mgorman@suse.de \
    --cc=paul.gortmaker@windriver.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pefoley2@pefoley.com \
    --cc=zhenglong.cai@cs2c.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox