From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753910AbaIOQDb (ORCPT ); Mon, 15 Sep 2014 12:03:31 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:41116 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbaIOQDa (ORCPT ); Mon, 15 Sep 2014 12:03:30 -0400 Date: Mon, 15 Sep 2014 17:02:41 +0100 From: Will Deacon To: "behanw@converseincode.com" Cc: "anderson@redhat.com" , Catalin Marinas , "jays.lee@samsung.com" , "msalter@redhat.com" , "steve.capper@linaro.org" , "akpm@linux-foundation.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Mark Charlebois Subject: Re: [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with clang Message-ID: <20140915160240.GC29744@arm.com> References: <20140909101515.GB1754@arm.com> <1410759015-15642-1-git-send-email-behanw@converseincode.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410759015-15642-1-git-send-email-behanw@converseincode.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 15, 2014 at 06:30:15AM +0100, behanw@converseincode.com wrote: > From: Mark Charlebois > > Remove '#' from immediate parameter in AARCH64 inline assembly in mmu. > > This code now works with both gcc and clang. > > Signed-off-by: Mark Charlebois > Signed-off-by: Behan Webster > --- > arch/arm64/mm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Will Deacon Thanks, Behan! Catalin: please can you pick this up for 3.18? It's probably not worth me merging it as a fix, since there are other patches needed to get us building under clang anyway. Will > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index c555672..6894ef3 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -94,7 +94,7 @@ static int __init early_cachepolicy(char *p) > */ > asm volatile( > " mrs %0, mair_el1\n" > - " bfi %0, %1, #%2, #8\n" > + " bfi %0, %1, %2, #8\n" > " msr mair_el1, %0\n" > " isb\n" > : "=&r" (tmp) > -- > 1.9.1 > >