From: Oleg Nesterov <oleg@redhat.com>
To: Roman Pen <r.peniaev@gmail.com>
Cc: Ming Lei <ming.lei@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] init: fix race between rootfs mount and firmware loading
Date: Mon, 15 Sep 2014 18:39:35 +0200 [thread overview]
Message-ID: <20140915163935.GB22768@redhat.com> (raw)
In-Reply-To: <1410792308-21577-1-git-send-email-r.peniaev@gmail.com>
On 09/15, Roman Pen wrote:
>
> +static DECLARE_COMPLETION(rootfs_mounted);
> +
> +void wait_for_rootfs(void)
> +{
> + /* Avoid waiting for ourselves */
> + if (is_global_init(current))
> + pr_warn("it is not a good idea to wait for rootfs mount from init task\n");
> + else
> + wait_for_completion(&rootfs_mounted);
> +}
> +
> +static inline void wake_up_rootfs_waiters(void)
> +{
> + complete(&rootfs_mounted);
> +}
Probably you need complete_all() ?
Otherwise wait_for_rootfs() can return only once, the next call will block
forever. And perhaps it would be better to use another primitive, even if
UINT_MAX/2 should be enough.
Oleg.
next prev parent reply other threads:[~2014-09-15 16:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 14:45 [PATCH 1/1] init: fix race between rootfs mount and firmware loading Roman Pen
2014-09-15 16:39 ` Oleg Nesterov [this message]
2014-09-17 13:18 ` Roman Peniaev
2014-09-17 13:28 ` [v2 PATCH " Roman Pen
2014-09-17 17:46 ` Oleg Nesterov
2014-09-18 13:31 ` Roman Peniaev
2014-09-18 17:28 ` Oleg Nesterov
2014-09-18 13:33 ` [v3 " Roman Pen
2014-09-18 17:41 ` Oleg Nesterov
2014-09-19 12:41 ` Roman Peniaev
2014-09-19 18:03 ` Oleg Nesterov
2014-09-19 12:44 ` [v4 " Roman Pen
2014-09-19 19:45 ` Oleg Nesterov
2014-09-20 13:20 ` Roman Peniaev
2014-09-19 21:42 ` Greg Kroah-Hartman
2014-09-20 13:18 ` Roman Peniaev
2014-09-20 14:42 ` Greg Kroah-Hartman
2014-09-20 15:12 ` Roman Peniaev
2014-09-17 17:59 ` [PATCH " Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915163935.GB22768@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=r.peniaev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).