From: Darren Hart <dvhart@infradead.org>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] toshiba_acpi: Support new keyboard backlight type
Date: Mon, 15 Sep 2014 10:47:47 -0700 [thread overview]
Message-ID: <20140915174747.GB59389@vmdeb7> (raw)
In-Reply-To: <1410569437-3066-1-git-send-email-coproscefalo@gmail.com>
On Fri, Sep 12, 2014 at 06:50:36PM -0600, Azael Avalos wrote:
> Newer Toshiba models now come with a new (and different) keyboard
> backlight implementation with three modes of operation: TIMER,
> ON and OFF, and the LED is now controlled internally by the firmware.
>
> This patch adds support for that type of backlight, changing the
> existing code to accomodate the new implementation.
>
> The timeout value range is now 1-60 seconds, and the accepted
> modes are now: 1 (FN-Z), 2 (AUTO or TIMER), 8 (ON) and 10 (OFF),
> this adds two new entries kbd_type and available_kbd_modes,
> the first shows the keyboard type and the latter shows the
> supported modes depending on the keyboard type.
>
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
> ---
> Changes since v3:
> Fixed typos on patch description
> Dropped changes to toshiba_kbd_bl_mode_show and simply added the new mode mask
> drivers/platform/x86/toshiba_acpi.c | 188 ++++++++++++++++++++++++++++++------
> 1 file changed, 156 insertions(+), 32 deletions(-)
Queued, thanks Azael.
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2014-09-15 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 0:50 [PATCH v4 4/5] toshiba_acpi: Support new keyboard backlight type Azael Avalos
2014-09-13 0:50 ` [PATCH v2 3/5] toshiba_acpi: Fix accelerometer direction reporting Azael Avalos
2014-09-15 19:29 ` Darren Hart
2014-09-15 19:56 ` Greg Kroah-Hartman
2014-09-15 21:01 ` H. Peter Anvin
2014-09-15 21:13 ` Darren Hart
2014-09-15 17:47 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915174747.GB59389@vmdeb7 \
--to=dvhart@infradead.org \
--cc=coproscefalo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox