From: Arnd Bergmann <arnd@arndb.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Alan Cox <alan@linux.intel.com>, Ning Li <ning.li@intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] gpio: Increase ARCH_NR_GPIOs to 512
Date: Mon, 15 Sep 2014 18:50:34 +0200 [thread overview]
Message-ID: <201409151850.34472.arnd@arndb.de> (raw)
In-Reply-To: <1410790185-31101-1-git-send-email-mika.westerberg@linux.intel.com>
On Monday 15 September 2014, Mika Westerberg wrote:
> Some newer Intel SoCs, like Braswell already have more than 256 GPIOs
> available so the default limit is exceeded. Instead of adding more
> architecture specific gpio.h files with custom ARCH_NR_GPIOs we increase
> the gpiolib default limit to be twice the current.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Changes to previous version is that now we increase the common limit
> instead of adding x86 specific gpio.h
Can you please include the reasoning for this decision in the
changeset description? I'm sure you have your reasons, but from
the text above, it sounds like a rather bad idea. What other
architectures are impacted by this, and what is the kernel size
cost for it on those architectures?
Arnd
next prev parent reply other threads:[~2014-09-15 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 14:09 [PATCH v2 1/2] gpio: Increase ARCH_NR_GPIOs to 512 Mika Westerberg
2014-09-15 14:09 ` [PATCH v2 2/2] gpio: Add support for Intel Cherryview/Braswell GPIO controller Mika Westerberg
2014-09-22 11:19 ` Mika Westerberg
2014-09-24 9:10 ` Linus Walleij
2014-09-24 9:12 ` Linus Walleij
2014-09-24 9:29 ` Mika Westerberg
2014-09-15 16:50 ` Arnd Bergmann [this message]
2014-09-16 9:34 ` [PATCH v2 1/2] gpio: Increase ARCH_NR_GPIOs to 512 Mika Westerberg
2014-09-23 15:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409151850.34472.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alan@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ning.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox