From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Chanho Park <chanho61.park@samsung.com>
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: define _DEFAULT_SOURCE for glibc_2.20
Date: Mon, 15 Sep 2014 16:06:55 -0300 [thread overview]
Message-ID: <20140915190655.GH11199@kernel.org> (raw)
In-Reply-To: <1410487817-13403-1-git-send-email-chanho61.park@samsung.com>
Em Fri, Sep 12, 2014 at 11:10:17AM +0900, Chanho Park escreveu:
> _BSD_SOURCE was deprecated in favour of _DEFAULT_SOURCE since glibc
> 2.20[1]. To avoid build warning on glibc2.20, _DEFAULT_SOURCE should
> also be defined.
>
> [1]: https://sourceware.org/glibc/wiki/Release/2.20
Thanks,
Applied.
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
> tools/perf/util/util.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> index 6686436..333d9d1 100644
> --- a/tools/perf/util/util.h
> +++ b/tools/perf/util/util.h
> @@ -39,6 +39,8 @@
>
> #define _ALL_SOURCE 1
> #define _BSD_SOURCE 1
> +/* glibc 2.20 deprecates _BSD_SOURCE in favour of _DEFAULT_SOURCE */
> +#define _DEFAULT_SOURCE 1
> #define HAS_BOOL
>
> #include <unistd.h>
> --
> 1.9.1
next prev parent reply other threads:[~2014-09-15 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 2:10 [PATCH] perf tools: define _DEFAULT_SOURCE for glibc_2.20 Chanho Park
2014-09-15 19:06 ` Arnaldo Carvalho de Melo [this message]
2014-09-19 5:22 ` [tip:perf/core] " tip-bot for Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915190655.GH11199@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=chanho61.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox