From: Shawn Guo <shawn.guo@freescale.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Robin Gong <b38343@freescale.com>, <kernel@pengutronix.de>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <linux@arm.linux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl
Date: Tue, 16 Sep 2014 09:43:06 +0800 [thread overview]
Message-ID: <20140916014304.GA23450@dragon> (raw)
In-Reply-To: <1410774073.3314.1.camel@pengutronix.de>
On Mon, Sep 15, 2014 at 11:41:13AM +0200, Lucas Stach wrote:
> Am Mittwoch, den 10.09.2014, 13:30 +0800 schrieb Robin Gong:
> > There is one weird data in rxfifo after one full rx/tx transfer
> > done sometimes. It looks a design issue and hard to workaround
> > totally, so disable dma functhion here. And will re-enable it
> > once the root cause found.
> >
> Sorry, I'm late to this as Shawn seems to already have picked up this
> patch, but this isn't the right way to fix the problem.
>
> We made it clear at kernel summit last year that we try to not break
> existing DTs as booting a new kernel with an old DT is a valid use case.
> While you don't strictly violate this rule what you do here is only
> fixing systems booting with a new DT while leaving others broken.
>
> If you are working around a hardware problem please disable DMA support
> in the driver. This will also allow you to enable it again, if you find
> another workaround without touching the DT again.
Okay, it's a valid point. Patch dropped.
Shawn
next prev parent reply other threads:[~2014-09-16 1:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 5:30 [PATCH v2] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl Robin Gong
2014-09-11 8:02 ` Shawn Guo
2014-09-15 9:41 ` Lucas Stach
2014-09-16 1:43 ` Shawn Guo [this message]
2014-09-16 3:41 ` Robin Gong
2014-09-16 9:50 ` Lucas Stach
2014-09-17 8:41 ` Robin Gong
2014-09-17 8:55 ` Lucas Stach
2014-09-17 9:19 ` Robin Gong
2014-09-17 9:19 ` Lucas Stach
2014-09-17 9:28 ` Robin Gong
2014-09-15 11:50 ` Alexander Holler
2014-09-16 3:52 ` Robin Gong
2014-09-16 9:41 ` Alexander Holler
2014-09-17 8:51 ` Robin Gong
2014-09-17 10:56 ` Alexander Holler
-- strict thread matches above, loose matches on Subject: below --
2014-10-21 1:06 Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916014304.GA23450@dragon \
--to=shawn.guo@freescale.com \
--cc=b38343@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).