Re: [PATCH] x86: Consider multiple nodes in a single socket to be "sane"

Borislav Petkov
2014-09-17T12:55:40Z

On Tue, Sep 16, 2014 at 01:17:44AM -0700, Dave Hansen wrote:
> >> This also fixes sysfs because CPUs with the same 'physical_package_id'
> >> in /sys/devices/system/cpu/cpu*/topology/ are not listed together
> >> in the same 'core_siblings_list'. This violates a statement from
> >> Documentation/ABI/testing/sysfs-devices-system-cpu:
> >>
> >> core_siblings: internal kernel map of cpu#'s hardware threads
> >> within the same physical_package_id.
> >>
> >> core_siblings_list: human-readable list of the logical CPU
> >> numbers within the same physical_package_id as cpu#.
> >
> > No that statement is wrong; it assumes physical_package_id is a good
> > identifier for nodes. Clearly this is no longer true.
>
> I went back and re-read the text around there. I don't see any mention
> of nodes or NUMA. It's just talking about the topology within the CPU
> from what I can tell.
>
> Good thing it's just in "Documentation/ABI/testing/" I guess.
>
> Either way, are you saying that a core's "physical_package_id" should
> depend on what BIOS options get set, and that different cores in the
> same physical package should have different "physical_package_id"s?

This sounds misleading to me. If I would have to explain how I
understand physical_package_id, I'd say it is the physical piece of
silicon containing the core. Which is consistent with what Peter says
that using it to identify NUMA nodes is wrong.

Btw, I'm trying to get on an AMD MCM box to dump those fields but it is
kinda hard currently. Will report back once I have something...

--
Regards/Gruss,
Boris.
--