Re: [PATCH] x86/vdso: use NULL instead of zero

Ingo Molnar
2014-09-16T08:36:24Z

* Michele Curti <michele.curti@gmail.com> wrote:

>
> x86/vdso: use NULL instead of zero in patch_vdso32()
>
> Signed-off-by: Michele Curti <michele.curti@gmail.com>
>
> diff --git a/arch/x86/vdso/vma.c b/arch/x86/vdso/vma.c
> index 1ad1026..a4647bc 100644
> --- a/arch/x86/vdso/vma.c
> +++ b/arch/x86/vdso/vma.c
> @@ -34,7 +34,7 @@ static unsigned vdsox32_size;
> void __init patch_vdso32(void *vdso, size_t len)
> {
> Elf32_Ehdr *hdr = vdso;
> - Elf32_Shdr *sechdrs, *alt_sec = 0;
> + Elf32_Shdr *sechdrs, *alt_sec = NULL;
> char *secstrings;
> void *alt_data;
> int i;

Your patch does not apply, this code got significantly reworked
in the following commit, earlier this year:

6f121e548f83 x86, vdso: Reimplement vdso.so preparation in build-time C

Thanks,

Ingo