From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753923AbaIPVzL (ORCPT ); Tue, 16 Sep 2014 17:55:11 -0400 Received: from imap.thunk.org ([74.207.234.97]:60783 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753154AbaIPVzI (ORCPT ); Tue, 16 Sep 2014 17:55:08 -0400 Date: Tue, 16 Sep 2014 17:55:02 -0400 From: "Theodore Ts'o" To: Rasmus Villemoes Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/22] treewide: Replace strnicmp with strncasecmp Message-ID: <20140916215502.GN6205@thunk.org> Mail-Followup-To: Theodore Ts'o , Rasmus Villemoes , Andrew Morton , linux-kernel@vger.kernel.org References: <1410900696-6481-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410900696-6481-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 16, 2014 at 10:51:14PM +0200, Rasmus Villemoes wrote: > The kernel used to contain two functions for length-delimited, > case-insensitive string comparison, strnicmp with correct semantics > and a slightly buggy strncasecmp. The latter is the POSIX name, so > strnicmp was renamed to strncasecmp, and strnicmp made into a wrapper > for the new strncasecmp to avoid breaking existing users. For the sake of those people who need to review the patches, can you say a bit more about the difference in semantics between strnicmp and strncasecmp, and why it's safe to do a global search and replace without worrying about the semantic differences? Thanks, - Ted