From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755003AbaIQD0H (ORCPT ); Tue, 16 Sep 2014 23:26:07 -0400 Received: from mail-bl2on0112.outbound.protection.outlook.com ([65.55.169.112]:29769 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753905AbaIQD0F (ORCPT ); Tue, 16 Sep 2014 23:26:05 -0400 Date: Wed, 17 Sep 2014 11:32:32 +0800 From: Robin Gong To: Shawn Guo CC: , , , , , , , , , , , , , , Subject: Re: [PATCH v2 1/3] ARM: dts: imx6: add pm_power_off support for i.mx6 chips Message-ID: <20140917033230.GD27452@Robin-OptiPlex-780> References: <1410511739-31122-1-git-send-email-b38343@freescale.com> <1410511739-31122-2-git-send-email-b38343@freescale.com> <20140917014723.GB4796@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20140917014723.GB4796@dragon> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:CAL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(24454002)(189002)(51704005)(199003)(104016003)(92566001)(85852003)(84676001)(21056001)(50986999)(87936001)(50466002)(46406003)(102836001)(31966008)(97756001)(97736003)(95666004)(33716001)(85306004)(74502003)(47776003)(107046002)(64706001)(92726001)(19580395003)(83506001)(76176999)(33656002)(80022003)(105606002)(20776003)(79102003)(110136001)(99396002)(6806004)(26826002)(90102001)(54356999)(76482002)(106466001)(44976005)(23726002)(81342003)(68736004)(83322001)(83072002)(4396001)(46102003)(19580405001)(77982003)(74662003)(81542003)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR03MB352;H:tx30smr01.am.freescale.net;FPR:;MLV:ovrnspm;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;UriScan:; X-Forefront-PRVS: 0337AFFE9A Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=yibin.gong@freescale.com; X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 17, 2014 at 09:47:24AM +0800, Shawn Guo wrote: > On Fri, Sep 12, 2014 at 04:48:57PM +0800, Robin Gong wrote: > > All chips of i.mx6 can be powered off by programming SNVS. > > For example : > > On i.mx6q-sabresd board, PMIC_ON_REQ connect with external > > pmic ON/OFF pin, that will cause the whole PMIC powered off > > except VSNVS. And system can restart once PMIC_ON_REQ goes > > high by push POWRER key. > > > > Signed-off-by: Robin Gong > > --- > > .../bindings/power_supply/imx-snvs-poweroff.txt | 21 +++++++++++++++++++++ > > Binding docs should be generally a separate patch or in the driver > patch, which uses the bindings. > > Shawn > Ok, I'll split it. > > arch/arm/boot/dts/imx6qdl.dtsi | 5 +++++ > > arch/arm/boot/dts/imx6sl.dtsi | 5 +++++ > > arch/arm/boot/dts/imx6sx.dtsi | 5 +++++ > > 4 files changed, 36 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/power_supply/imx-snvs-poweroff.txt > > > > diff --git a/Documentation/devicetree/bindings/power_supply/imx-snvs-poweroff.txt b/Documentation/devicetree/bindings/power_supply/imx-snvs-poweroff.txt > > new file mode 100644 > > index 0000000..1a3ab9a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power_supply/imx-snvs-poweroff.txt > > @@ -0,0 +1,21 @@ > > +i.mx6 Poweroff Driver > > + > > +SNVS_LPCR in SNVS module can power off the whole system by pull > > +PMIC_ON_REQ low. > > + > > +Required Properties: > > +-compatible: "fsl,sec-v4.0-poweroff" > > +-reg: Specifies the physical address of the SNVS_LPCR register > > + > > +Example: > > + snvs@020cc000 { > > + compatible = "fsl,sec-v4.0-mon", "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x020cc000 0x4000>; > > + ..... > > + snvs-poweroff@38 { > > + compatible = "fsl,sec-v4.0-poweroff"; > > + reg = <0x38 0x4>; > > + }; > > + } > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > > index 70d7207..d2d7563 100644 > > --- a/arch/arm/boot/dts/imx6qdl.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > > @@ -650,6 +650,11 @@ > > interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>, > > <0 20 IRQ_TYPE_LEVEL_HIGH>; > > }; > > + > > + snvs-poweroff@38 { > > + compatible = "fsl,sec-v4.0-poweroff"; > > + reg = <0x38 0x4>; > > + }; > > }; > > > > epit1: epit@020d0000 { /* EPIT1 */ > > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi > > index ba67714..6e1d8f6 100644 > > --- a/arch/arm/boot/dts/imx6sl.dtsi > > +++ b/arch/arm/boot/dts/imx6sl.dtsi > > @@ -568,6 +568,11 @@ > > interrupts = <0 19 IRQ_TYPE_LEVEL_HIGH>, > > <0 20 IRQ_TYPE_LEVEL_HIGH>; > > }; > > + > > + snvs-poweroff@38 { > > + compatible = "fsl,sec-v4.0-poweroff"; > > + reg = <0x38 0x4>; > > + }; > > }; > > > > epit1: epit@020d0000 { > > diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi > > index d137caca..c1f937e 100644 > > --- a/arch/arm/boot/dts/imx6sx.dtsi > > +++ b/arch/arm/boot/dts/imx6sx.dtsi > > @@ -671,6 +671,11 @@ > > reg = <0x34 0x58>; > > interrupts = , ; > > }; > > + > > + snvs-poweroff@38 { > > + compatible = "fsl,sec-v4.0-poweroff"; > > + reg = <0x38 0x4>; > > + }; > > }; > > > > epit1: epit@020d0000 { > > -- > > 1.9.1 > >