From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kieron Browne <kieron.browne@gmail.com>
Cc: Larry.Finger@lwfinger.net, Jes.Sorensen@redhat.com,
gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: rtl8723au: fix sparse incorrect type assignment warnings
Date: Wed, 17 Sep 2014 11:26:27 +0300 [thread overview]
Message-ID: <20140917082627.GH17875@mwanda> (raw)
In-Reply-To: <1410906489-26671-1-git-send-email-kieron.browne@gmail.com>
On Tue, Sep 16, 2014 at 11:28:09PM +0100, Kieron Browne wrote:
> Use cpu_to_le16 to cast int for assignment to __le16 members
>
"cast" is the wrong word. It's really doing a byte swap. It fixes a
bug on big endian systems.
But the patch is ok and matches how the other rtl drivers do it.
regards,
dan carpenter
prev parent reply other threads:[~2014-09-17 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 22:28 [PATCH 1/1] staging: rtl8723au: fix sparse incorrect type assignment warnings Kieron Browne
2014-09-17 8:26 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917082627.GH17875@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kieron.browne@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).