From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755323AbaIQLfR (ORCPT ); Wed, 17 Sep 2014 07:35:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40605 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755199AbaIQLfN (ORCPT ); Wed, 17 Sep 2014 07:35:13 -0400 Date: Wed, 17 Sep 2014 13:35:00 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] kvm: Faults which trigger IO release the mmap_sem Message-ID: <20140917113458.GA1462@potion.brq.redhat.com> References: <1410811885-17267-1-git-send-email-andreslc@google.com> <54184078.4070505@redhat.com> <20140916205110.GA1273@potion.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Repost for lists, the last mail was eaten by a security troll.] 2014-09-16 14:01-0700, Andres Lagar-Cavilla: > On Tue, Sep 16, 2014 at 1:51 PM, Radim Krčmář > wrote: > > 2014-09-15 13:11-0700, Andres Lagar-Cavilla: > >> +int kvm_get_user_page_retry(struct task_struct *tsk, struct > >> mm_struct *mm, > > > > The suffix '_retry' is not best suited for this. > > On first reading, I imagined we will be retrying something from > > before, > > possibly calling it in a loop, but we are actually doing the first > > and > > last try in one call. > > We are doing ... the second and third in most scenarios. async_pf did > the first with _NOWAIT. We call this from the async pf retrier, or if > async pf couldn't be notified to the guest. I was thinking more about what the function does, not how we currently use it -- nothing prevents us from using it as first somewhere -- but yeah, even comments would be off then. > >> Apart from this, the patch looks good. The mm/ parts are minimal, > >> so > >> I > >> think it's best to merge it through the KVM tree with someone's > >> Acked-by. > > > > I would prefer to have the last hunk in a separate patch, but still, > > > > Acked-by: Radim Krčmář > > Awesome, thanks much. > > I'll recut with the VM_BUG_ON from Paolo and your Ack. LMK if anything > else from this email should go into the recut. Ah, sorry, I'm not maintaining mm ... what I meant was Reviewed-by: Radim Krčmář and I had to leave before I could find a good apology for VM_WARN_ON_ONCE(), so if you are replacing BUG_ON, you might want to look at that one as well.