From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755634AbaIQNsA (ORCPT ); Wed, 17 Sep 2014 09:48:00 -0400 Received: from imap.thunk.org ([74.207.234.97]:33679 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755612AbaIQNr6 (ORCPT ); Wed, 17 Sep 2014 09:47:58 -0400 Date: Wed, 17 Sep 2014 09:47:02 -0400 From: "Theodore Ts'o" To: Benjamin LaHaise Cc: Dave Chinner , Milosz Tanski , Jeff Moyer , LKML , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , linux-aio@kvack.org, Mel Gorman , Volker Lendecke , Tejun Heo Subject: Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances Message-ID: <20140917134702.GB10720@thunk.org> Mail-Followup-To: Theodore Ts'o , Benjamin LaHaise , Dave Chinner , Milosz Tanski , Jeff Moyer , LKML , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , linux-aio@kvack.org, Mel Gorman , Volker Lendecke , Tejun Heo References: <20140916214254.GK4322@dastard> <20140917122448.GR24821@kvack.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140917122448.GR24821@kvack.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 17, 2014 at 08:24:48AM -0400, Benjamin LaHaise wrote: > > Linus flamed me for that a few weeks ago. The problem is that if one > uses "git format-patch" to prepare a series of emails to post, that it > users the patch's author for the From: entry. I think that is a bug > in git since multiple people have encountered this issue. It's not > like git doesn't know what one's email address is.... That's true, but "git send-email" takes care of doing the rewrite so that your e-mail address is on the from line and the original author's from: line is moved into the body of the e-mail: % git log -1 commit 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10 Author: Michael Forney Date: Mon Sep 15 14:30:00 2014 -0400 Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling Signed-off-by: Michael Forney Signed-off-by: Theodore Ts'o % git format-patch -o /tmp/p -1 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch % head -5 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch >>From 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10 Mon Sep 17 00:00:00 2001 From: Michael Forney Date: Mon, 15 Sep 2014 14:30:00 -0400 Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling % git send-email /tmp/p --to tytso@mit.edu /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch (mbox) Adding cc: Michael Forney from line 'From: Michael Forney ' (body) Adding cc: Michael Forney from line 'Signed-off-by: Michael Forney ' (body) Adding cc: Theodore Ts'o from line 'Signed-off-by: Theodore Ts'o ' From: Theodore Ts'o To: tytso@mit.edu Cc: Michael Forney Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling Date: Wed, 17 Sep 2014 09:45:09 -0400 Message-Id: <1410961509-10620-1-git-send-email-tytso@mit.edu> X-Mailer: git-send-email 2.1.0 Send this email? ([y]es|[n]o|[q]uit|[a]ll): ^C % git version git version 2.1.0 Perhaps you and other people are using your own scripts, and not using git send-email? - Ted