From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755621AbaIQPrA (ORCPT ); Wed, 17 Sep 2014 11:47:00 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:33677 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754786AbaIQPq6 (ORCPT ); Wed, 17 Sep 2014 11:46:58 -0400 Date: Wed, 17 Sep 2014 08:46:53 -0700 From: Lee Jones To: Johan Hovold Cc: Octavian Purdila , gregkh@linuxfoundation.org, linus.walleij@linaro.org, gnurou@gmail.com, wsa@the-dreams.de, sameo@linux.intel.com, arnd@arndb.de, daniel.baluta@intel.com, laurentiu.palcu@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices Message-ID: <20140917154653.GF30918@lee--X1> References: <1410290686-6680-1-git-send-email-octavian.purdila@intel.com> <1410290686-6680-2-git-send-email-octavian.purdila@intel.com> <20140917091001.GF20727@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140917091001.GF20727@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Sep 2014, Johan Hovold wrote: > On Tue, Sep 09, 2014 at 10:24:44PM +0300, Octavian Purdila wrote: > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > > Master Adapter DLN-2. Details about the device can be found here: > > > > https://www.diolan.com/i2c/i2c_interface.html. > > > > Information about the USB protocol can be found in the Programmer's > > Reference Manual [1], see section 1.7. > > > > Because the hardware has a single transmit endpoint and a single > > receive endpoint the communication between the various DLN2 drivers > > and the hardware will be muxed/demuxed by this driver. > > > > Each DLN2 module will be identified by the handle field within the DLN2 > > message header. If a DLN2 module issues multiple commands in parallel > > they will be identified by the echo counter field in the message header. > > > > The DLN2 modules can use the dln2_transfer() function to issue a > > command and wait for its response. They can also register a callback > > that is going to be called when a specific event id is generated by > > the device (e.g. GPIO interrupts). The device uses handle 0 for > > sending events. > > > > [1] https://www.diolan.com/downloads/dln-api-manual.pdf > > > > Signed-off-by: Octavian Purdila > > --- > > drivers/mfd/Kconfig | 9 + > > drivers/mfd/Makefile | 1 + > > drivers/mfd/dln2.c | 681 +++++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/mfd/dln2.h | 71 +++++ > > 4 files changed, 762 insertions(+) > > create mode 100644 drivers/mfd/dln2.c > > create mode 100644 include/linux/mfd/dln2.h [...] > Unless anyone suggests otherwise (e.g. to stick with auto id), I'll add > a helper function for this and fix up those two drivers. Appreciated. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog