From: Lee Jones <lee.jones@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: ssbi: promote the driver to subsys level
Date: Wed, 17 Sep 2014 09:03:05 -0700 [thread overview]
Message-ID: <20140917160305.GH30918@lee--X1> (raw)
In-Reply-To: <1410915594-15599-1-git-send-email-srinivas.kandagatla@linaro.org>
On Wed, 17 Sep 2014, Srinivas Kandagatla wrote:
> This patch promtes the driver to be at subsystem level as this driver
> will be used by gpio controller drivers which inturn are used by many
> platform drivers.
Any reason why you're not using -EPROBE?
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/mfd/ssbi.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
> index b78942e..4fbe02e 100644
> --- a/drivers/mfd/ssbi.c
> +++ b/drivers/mfd/ssbi.c
> @@ -331,7 +331,12 @@ static struct platform_driver ssbi_driver = {
> .of_match_table = ssbi_match_table,
> },
> };
> -module_platform_driver(ssbi_driver);
> +
> +static int ssbi_init(void)
> +{
> + return platform_driver_register(&ssbi_driver);
> +}
> +subsys_initcall(ssbi_init);
>
> MODULE_LICENSE("GPL v2");
> MODULE_VERSION("1.0");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-09-17 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 0:59 [PATCH] mfd: ssbi: promote the driver to subsys level Srinivas Kandagatla
2014-09-17 16:03 ` Lee Jones [this message]
[not found] ` <CAGkH4DOPHQWBVZgiLZugcoTZNJiS-ar8KNvq96W5UmX8C6GCTg@mail.gmail.com>
2014-09-17 16:49 ` Lee Jones
2014-09-17 22:25 ` Lee Jones
2014-09-17 22:34 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917160305.GH30918@lee--X1 \
--to=lee.jones@linaro.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox