From: Oleg Nesterov <oleg@redhat.com>
To: Roman Peniaev <r.peniaev@gmail.com>
Cc: Ming Lei <ming.lei@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] init: fix race between rootfs mount and firmware loading
Date: Wed, 17 Sep 2014 19:59:44 +0200 [thread overview]
Message-ID: <20140917175944.GD19308@redhat.com> (raw)
In-Reply-To: <CACZ9PQXJzoczS7gN5UCFygTHrLW5Rtjew5BF-txfL=cryE331w@mail.gmail.com>
On 09/17, Roman Peniaev wrote:
>
> On Tue, Sep 16, 2014 at 1:39 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> > On 09/15, Roman Pen wrote:
> >>
> >
> > Otherwise wait_for_rootfs() can return only once, the next call will block
> > forever. And perhaps it would be better to use another primitive, even if
> > UINT_MAX/2 should be enough.
>
> And why do you think completion is not good for this?
> Seems it is impossible to have so many threads on early init, which wait
> for rootfs.
Yes, but it is not only called during init? Suppose that a user does
insmod + rmmod in a loop, and the driver calls request_firmware(). This
will hang after UINT_MAX/2 iterations. Sure, this can't happen in practice,
but still this doesn't look good imho.
Oleg.
prev parent reply other threads:[~2014-09-17 18:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 14:45 [PATCH 1/1] init: fix race between rootfs mount and firmware loading Roman Pen
2014-09-15 16:39 ` Oleg Nesterov
2014-09-17 13:18 ` Roman Peniaev
2014-09-17 13:28 ` [v2 PATCH " Roman Pen
2014-09-17 17:46 ` Oleg Nesterov
2014-09-18 13:31 ` Roman Peniaev
2014-09-18 17:28 ` Oleg Nesterov
2014-09-18 13:33 ` [v3 " Roman Pen
2014-09-18 17:41 ` Oleg Nesterov
2014-09-19 12:41 ` Roman Peniaev
2014-09-19 18:03 ` Oleg Nesterov
2014-09-19 12:44 ` [v4 " Roman Pen
2014-09-19 19:45 ` Oleg Nesterov
2014-09-20 13:20 ` Roman Peniaev
2014-09-19 21:42 ` Greg Kroah-Hartman
2014-09-20 13:18 ` Roman Peniaev
2014-09-20 14:42 ` Greg Kroah-Hartman
2014-09-20 15:12 ` Roman Peniaev
2014-09-17 17:59 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917175944.GD19308@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=r.peniaev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).