From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Ragnar B. Johannsson" <ragnar@igo.is>
Cc: gregkh@linuxfoundation.org, gdonald@gmail.com,
himangi774@gmail.com, joe@perches.com, joelpelaez@gmail.com,
arnd@arndb.de, jmmahler@gmail.com,
peter.p.waskiewicz.jr@intel.com, antoine@schweitzer-chaput.fr,
anarey@gmail.com, c@24.io,
rickard_strandqvist@spectrumdigital.se, teobaluta@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: rtl8192u: Move ieee80211_crypto_* declarations to ieee80211/ieee80211.h
Date: Thu, 18 Sep 2014 00:40:27 +0300 [thread overview]
Message-ID: <20140917214027.GM17875@mwanda> (raw)
In-Reply-To: <1410989043-53752-1-git-send-email-ragnar@igo.is>
On Wed, Sep 17, 2014 at 09:24:03PM +0000, Ragnar B. Johannsson wrote:
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> index bdad3a2..d56c3aac 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> @@ -2445,6 +2445,15 @@ extern void ieee80211_tkip_null(void);
> extern void ieee80211_wep_null(void);
> extern void ieee80211_ccmp_null(void);
>
> +extern int ieee80211_crypto_init(void);
> +extern void ieee80211_crypto_deinit(void);
> +extern int ieee80211_crypto_tkip_init(void);
> +extern void ieee80211_crypto_tkip_exit(void);
> +extern int ieee80211_crypto_ccmp_init(void);
> +extern void ieee80211_crypto_ccmp_exit(void);
> +extern int ieee80211_crypto_wep_init(void);
> +extern void ieee80211_crypto_wep_exit(void);
> +
We don't normally put the extern here. I don't think it adds anything
to the readability. Let's remove it.
regards,
dan carpenter
next prev parent reply other threads:[~2014-09-17 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 21:24 [PATCH 1/1] staging: rtl8192u: Move ieee80211_crypto_* declarations to ieee80211/ieee80211.h Ragnar B. Johannsson
2014-09-17 21:40 ` Dan Carpenter [this message]
2014-09-18 14:33 ` [PATCH v2 " Ragnar B. Johannsson
2014-09-18 15:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917214027.GM17875@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anarey@gmail.com \
--cc=antoine@schweitzer-chaput.fr \
--cc=arnd@arndb.de \
--cc=c@24.io \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=jmmahler@gmail.com \
--cc=joe@perches.com \
--cc=joelpelaez@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=ragnar@igo.is \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=teobaluta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox