From: Ralf Baechle <ralf@linux-mips.org>
To: minyard@acm.org
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH] mips: Save all registers when saving the frame
Date: Thu, 18 Sep 2014 11:58:13 +0200 [thread overview]
Message-ID: <20140918095813.GA9804@linux-mips.org> (raw)
In-Reply-To: <1410903925-10744-1-git-send-email-minyard@acm.org>
On Tue, Sep 16, 2014 at 04:45:25PM -0500, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> The MIPS frame save code was just saving a few registers, enough to
> do a backtrace if every function set up a frame. However, this is
> not working if you are using DWARF unwinding, because most of the
> registers are wrong. This was causing kdump backtraces to be short
> or bogus.
>
> So save all the registers.
The stratey of partial and full stack frames was developed in '97 to bring
down the syscall overhead. It certaily was very effective - it brought
down the syscall latency to the level of Alphas running at much higher
clock.
That certainly worked well back then for kernel 2.0 / 2.2. But the syscall
code has become much more complex. Since then support for 64 bit kernels,
two 32 bit ABIs running on a 64 bit kernels and numerous features that
changed the once simple syscall path have been implemented. My gut feeling
is it might be worth to yank out the whole optimization to see how much
code complexity we get rid of in exchange for how much extra syscall
latency.
Ralf
next prev parent reply other threads:[~2014-09-18 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 21:45 [PATCH] mips: Save all registers when saving the frame minyard
2014-09-16 23:24 ` Corey Minyard
2014-09-18 9:58 ` Ralf Baechle [this message]
2014-09-18 12:58 ` Corey Minyard
2014-09-23 16:12 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918095813.GA9804@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox