From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Ragnar B. Johannsson" <ragnar@igo.is>
Cc: gregkh@linuxfoundation.org, gdonald@gmail.com,
himangi774@gmail.com, joe@perches.com, joelpelaez@gmail.com,
arnd@arndb.de, jmmahler@gmail.com,
peter.p.waskiewicz.jr@intel.com, antoine@schweitzer-chaput.fr,
anarey@gmail.com, c@24.io,
rickard_strandqvist@spectrumdigital.se, teobaluta@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] staging: rtl8192u: Move ieee80211_crypto_* declarations to ieee80211/ieee80211.h
Date: Thu, 18 Sep 2014 18:04:16 +0300 [thread overview]
Message-ID: <20140918150416.GN17875@mwanda> (raw)
In-Reply-To: <1411050805-61907-1-git-send-email-ragnar@igo.is>
On Thu, Sep 18, 2014 at 02:33:25PM +0000, Ragnar B. Johannsson wrote:
> Move ieee80211_crypto*_init and _exit prototype declarations from r8192U_core.c to ieee80211/ieee80211.h. This fixes the following sparse warnings:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:203:12: warning: symbol 'ieee80211_crypto_init' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:223:13: warning: symbol 'ieee80211_crypto_deinit' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:764:12: warning: symbol 'ieee80211_crypto_tkip_init' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c:769:13: warning: symbol 'ieee80211_crypto_tkip_exit' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:467:12: warning: symbol 'ieee80211_crypto_ccmp_init' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:472:13: warning: symbol 'ieee80211_crypto_ccmp_exit' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c:281:12: warning: symbol 'ieee80211_crypto_wep_init' was not declared. Should it be static?
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c:286:13: warning: symbol 'ieee80211_crypto_wep_exit' was not declared. Should it be static?
>
> Signed-off-by: Ragnar B. Johannsson <ragnar@igo.is>
> ---
> Changes in v2: Remove extern, as suggested by Dan Carpenter.
Fantastic. Thanks!
regards,
dan carpenter
prev parent reply other threads:[~2014-09-18 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 21:24 [PATCH 1/1] staging: rtl8192u: Move ieee80211_crypto_* declarations to ieee80211/ieee80211.h Ragnar B. Johannsson
2014-09-17 21:40 ` Dan Carpenter
2014-09-18 14:33 ` [PATCH v2 " Ragnar B. Johannsson
2014-09-18 15:04 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918150416.GN17875@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anarey@gmail.com \
--cc=antoine@schweitzer-chaput.fr \
--cc=arnd@arndb.de \
--cc=c@24.io \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=jmmahler@gmail.com \
--cc=joe@perches.com \
--cc=joelpelaez@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=ragnar@igo.is \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=teobaluta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox