linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] Drivers: scsi: storvsc: Get rid of warning messages
@ 2014-09-02 23:43 K. Y. Srinivasan
  2014-09-05  5:40 ` Christoph Hellwig
  2014-09-18 16:20 ` Olaf Hering
  0 siblings, 2 replies; 10+ messages in thread
From: K. Y. Srinivasan @ 2014-09-02 23:43 UTC (permalink / raw)
  To: linux-kernel, devel, ohering, jbottomley, hch, linux-scsi
  Cc: K. Y. Srinivasan

Get rid of the warning messages since they will clutter up various system logs
and are of questionable value to the end user. For debugging purposes, this
information can be gotten by setting the scsi log level appropriately.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/scsi/storvsc_drv.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index fecac5d0..733e5f7 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1152,24 +1152,12 @@ static void storvsc_on_io_completion(struct hv_device *device,
 	stor_pkt->vm_srb.sense_info_length =
 	vstor_packet->vm_srb.sense_info_length;
 
-	if (vstor_packet->vm_srb.scsi_status != 0 ||
-		vstor_packet->vm_srb.srb_status != SRB_STATUS_SUCCESS){
-		dev_warn(&device->device,
-			 "cmd 0x%x scsi status 0x%x srb status 0x%x\n",
-			 stor_pkt->vm_srb.cdb[0],
-			 vstor_packet->vm_srb.scsi_status,
-			 vstor_packet->vm_srb.srb_status);
-	}
 
 	if ((vstor_packet->vm_srb.scsi_status & 0xFF) == 0x02) {
 		/* CHECK_CONDITION */
 		if (vstor_packet->vm_srb.srb_status &
 			SRB_STATUS_AUTOSENSE_VALID) {
 			/* autosense data available */
-			dev_warn(&device->device,
-				 "stor pkt %p autosense data valid - len %d\n",
-				 request,
-				 vstor_packet->vm_srb.sense_info_length);
 
 			memcpy(request->sense_buffer,
 			       vstor_packet->vm_srb.sense_data,
-- 
1.7.4.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2014-09-18 16:59 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02 23:43 [PATCH 1/1] Drivers: scsi: storvsc: Get rid of warning messages K. Y. Srinivasan
2014-09-05  5:40 ` Christoph Hellwig
2014-09-05  9:14   ` Sitsofe Wheeler
2014-09-08 19:17   ` KY Srinivasan
2014-09-17  7:33     ` Olaf Hering
2014-09-17 23:23       ` Christoph Hellwig
2014-09-18 11:50         ` Olaf Hering
2014-09-18 16:43           ` Christoph Hellwig
2014-09-18 16:44             ` KY Srinivasan
2014-09-18 16:20 ` Olaf Hering

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).