The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com,
	mingo@kernel.org, hpa@linux.intel.com, brice.goglin@gmail.com,
	bp@alien8.de
Subject: Re: [PATCH] x86: new topology for multi-NUMA-node CPUs
Date: Thu, 18 Sep 2014 22:49:06 +0200	[thread overview]
Message-ID: <20140918204906.GM2848@worktop.localdomain> (raw)
In-Reply-To: <20140918193334.C065EBCE@viggo.jf.intel.com>

On Thu, Sep 18, 2014 at 12:33:34PM -0700, Dave Hansen wrote:
> 
> 
> This is my third attempt to fix this.  It's definitely simpler
> than the previous set.  This takes Peter Z's suggestion to just
> create and use a different topology when we see these
> "Cluster-on-Die" systems.


> +static struct sched_domain_topology_level numa_inside_package_topology[] = {
> +#ifdef CONFIG_SCHED_SMT
> +	{ cpu_smt_mask, cpu_smt_flags, SD_INIT_NAME(SMT) },
> +#endif
> +	{ NULL, },
> +};

Yes, that looks ok. The only thing is that we need to fix the MC and DIE
masks. But I can do that in a separate patch. This should ideally still
contain the MC domain (as in LLC) mask, just not the DIE domain (as in
pkg).

But as you already saw, bits are somewhat icky atm.

  reply	other threads:[~2014-09-19 15:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 19:33 [PATCH] x86: new topology for multi-NUMA-node CPUs Dave Hansen
2014-09-18 20:49 ` Peter Zijlstra [this message]
2014-09-18 21:57 ` Dave Hansen
2014-09-19 11:45 ` Karel Zak
2014-09-19 18:15   ` Dave Hansen
2014-09-22  7:43     ` Karel Zak
2014-09-21 17:56 ` Brice Goglin
2014-09-24 14:58 ` [tip:sched/core] x86, sched: Add " tip-bot for Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140918204906.GM2848@worktop.localdomain \
    --to=peterz@infradead.org \
    --cc=bp@alien8.de \
    --cc=brice.goglin@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave@sr71.net \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox