* [PATCH] parisc: Use secure_computing_strict, not secure_computing
@ 2014-09-16 16:05 Andy Lutomirski
2014-09-16 16:06 ` Andy Lutomirski
2014-09-19 10:59 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Andy Lutomirski @ 2014-09-16 16:05 UTC (permalink / raw)
To: Ingo Molnar, hpa
Cc: linux-kernel, schwidefsky, keescook, linux, ralf, heiko.carstens,
tglx, Andy Lutomirski
After commit a4412fc9486e, the secure_computing function is only
available if seccomp filters are implemented by the architecture.
Architectures without seccomp filters use secure_computing_strict
instead.
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
This is minimally tested because my cross-compiler toolchain for parisc
is quite broken. ptrace.c seems to *compile*, but it doesn't assemble.
arch/parisc/kernel/ptrace.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/parisc/kernel/ptrace.c b/arch/parisc/kernel/ptrace.c
index 3bab72462ab5..5961cc86d6d2 100644
--- a/arch/parisc/kernel/ptrace.c
+++ b/arch/parisc/kernel/ptrace.c
@@ -270,11 +270,11 @@ long do_syscall_trace_enter(struct pt_regs *regs)
{
long ret = 0;
- /* Do the secure computing check first. */
- if (secure_computing(regs->gr[20])) {
- /* seccomp failures shouldn't expose any additional code. */
- return -1;
- }
+ /*
+ * Do the secure computing check first. seccomp failures
+ * shouldn't expose any additional code.
+ */
+ secure_computing_strict(regs->gr[20]);
if (test_thread_flag(TIF_SYSCALL_TRACE) &&
tracehook_report_syscall_entry(regs))
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] parisc: Use secure_computing_strict, not secure_computing
2014-09-16 16:05 [PATCH] parisc: Use secure_computing_strict, not secure_computing Andy Lutomirski
@ 2014-09-16 16:06 ` Andy Lutomirski
2014-09-19 10:59 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Andy Lutomirski @ 2014-09-16 16:06 UTC (permalink / raw)
To: Ingo Molnar, H. Peter Anvin
Cc: linux-kernel@vger.kernel.org, Martin Schwidefsky, Kees Cook,
Russell King, Ralf Baechle, Heiko Carstens, Thomas Gleixner,
Andy Lutomirski
On Tue, Sep 16, 2014 at 9:05 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> After commit a4412fc9486e, the secure_computing function is only
> available if seccomp filters are implemented by the architecture.
> Architectures without seccomp filters use secure_computing_strict
> instead.
>
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
> ---
>
> This is minimally tested because my cross-compiler toolchain for parisc
> is quite broken. ptrace.c seems to *compile*, but it doesn't assemble.
Failed to mention: this applies on top of what tip/master, aka what
happens when tip/seccomp is merged with a newer -linus kernel.
--Andy
>
> arch/parisc/kernel/ptrace.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/parisc/kernel/ptrace.c b/arch/parisc/kernel/ptrace.c
> index 3bab72462ab5..5961cc86d6d2 100644
> --- a/arch/parisc/kernel/ptrace.c
> +++ b/arch/parisc/kernel/ptrace.c
> @@ -270,11 +270,11 @@ long do_syscall_trace_enter(struct pt_regs *regs)
> {
> long ret = 0;
>
> - /* Do the secure computing check first. */
> - if (secure_computing(regs->gr[20])) {
> - /* seccomp failures shouldn't expose any additional code. */
> - return -1;
> - }
> + /*
> + * Do the secure computing check first. seccomp failures
> + * shouldn't expose any additional code.
> + */
> + secure_computing_strict(regs->gr[20]);
>
> if (test_thread_flag(TIF_SYSCALL_TRACE) &&
> tracehook_report_syscall_entry(regs))
> --
> 1.9.3
>
--
Andy Lutomirski
AMA Capital Management, LLC
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] parisc: Use secure_computing_strict, not secure_computing
2014-09-16 16:05 [PATCH] parisc: Use secure_computing_strict, not secure_computing Andy Lutomirski
2014-09-16 16:06 ` Andy Lutomirski
@ 2014-09-19 10:59 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2014-09-19 10:59 UTC (permalink / raw)
To: Andy Lutomirski
Cc: hpa, linux-kernel, schwidefsky, keescook, linux, ralf,
heiko.carstens, tglx, James E.J. Bottomley
(Cc:-ed the PARISC maintainer. Original patch quoted below.)
* Andy Lutomirski <luto@amacapital.net> wrote:
> After commit a4412fc9486e, the secure_computing function is only
> available if seccomp filters are implemented by the architecture.
> Architectures without seccomp filters use secure_computing_strict
> instead.
>
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
> ---
>
> This is minimally tested because my cross-compiler toolchain for parisc
> is quite broken. ptrace.c seems to *compile*, but it doesn't assemble.
>
> arch/parisc/kernel/ptrace.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/parisc/kernel/ptrace.c b/arch/parisc/kernel/ptrace.c
> index 3bab72462ab5..5961cc86d6d2 100644
> --- a/arch/parisc/kernel/ptrace.c
> +++ b/arch/parisc/kernel/ptrace.c
> @@ -270,11 +270,11 @@ long do_syscall_trace_enter(struct pt_regs *regs)
> {
> long ret = 0;
>
> - /* Do the secure computing check first. */
> - if (secure_computing(regs->gr[20])) {
> - /* seccomp failures shouldn't expose any additional code. */
> - return -1;
> - }
> + /*
> + * Do the secure computing check first. seccomp failures
> + * shouldn't expose any additional code.
> + */
> + secure_computing_strict(regs->gr[20]);
>
> if (test_thread_flag(TIF_SYSCALL_TRACE) &&
> tracehook_report_syscall_entry(regs))
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-19 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-16 16:05 [PATCH] parisc: Use secure_computing_strict, not secure_computing Andy Lutomirski
2014-09-16 16:06 ` Andy Lutomirski
2014-09-19 10:59 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox