Re: [PATCH 0/2] perf tool: improve error handling in perf_flag_probe()

[Jiri Olsa <jolsa@redhat.com>]

On Sat, Sep 13, 2014 at 10:46:22AM +0200, Yann Droneaud wrote:
> Hi,
> 
> Following the EBUSY errors reported by Jiri Olsa [1], I've tryed to
> improve a bit the way perf_flag_probe() handle errors.
> 
> In case EBUSY is returned by perf_event_open(), testing the function
> again without PERF_FLAG_FD_CLOEXEC is meaningless: EBUSY is not
> related to close-on-exec flag, so there's nothing to confirm.
> 
> For other errors, not yet handled by perf_flag_probe(), it's
> pointless to report a second error message for the same error code:
> the second check should not print an error if the error is the same
> as the one return for the first check.
> 
> [1] http://lkml.kernel.org/r/1406908014-8312-1-git-send-email-jolsa@kernel.org
> 
> Yann Droneaud (2):
>   perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY
>     error
>   perf tools: report PERF_FLAG_FD_CLOEXEC probing error once

seems good to me, for the patchset:
Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka