From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Grzegorz Swirski <grzegorz@swirski.name>
Cc: gregkh@linuxfoundation.org, josh@joshtriplett.org,
stankus.modestas@gmail.com, vitaly.osipov@gmail.com,
Johannes.Stadlinger@fau.de, himangi774@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: remove unused 'result' var
Date: Sat, 20 Sep 2014 23:46:35 +0530 [thread overview]
Message-ID: <20140920181635.GA2379@sudip-PC> (raw)
In-Reply-To: <1411211351-4207-1-git-send-email-grzegorz@swirski.name>
On Sat, Sep 20, 2014 at 12:09:11PM +0100, Grzegorz Swirski wrote:
> Signed-off-by: Grzegorz Swirski <grzegorz@swirski.name>
you have not mentioned any commit log
> ---
> drivers/staging/wlan-ng/prism2mib.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index f471708..0163e06 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -717,8 +717,6 @@ static int prism2mib_priv(struct mibrec *mib,
> {
> p80211pstrd_t *pstr = (p80211pstrd_t *) data;
>
> - int result;
> -
> switch (mib->did) {
> case DIDmib_lnx_lnxConfigTable_lnxRSNAIE:{
> hfa384x_WPAData_t wpa;
> @@ -734,11 +732,10 @@ static int prism2mib_priv(struct mibrec *mib,
> wpa.datalen = cpu_to_le16(pstr->len);
> memcpy(wpa.data, pstr->data, pstr->len);
>
> - result =
> - hfa384x_drvr_setconfig(hw,
> - HFA384x_RID_CNFWPADATA,
> - (u8 *) &wpa,
> - sizeof(wpa));
> + hfa384x_drvr_setconfig(hw,
> + HFA384x_RID_CNFWPADATA,
> + (u8 *) &wpa,
if you check your patch with --strict option then you will see one warning here.
thanks
sudip
> + sizeof(wpa));
> }
> break;
> }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-09-20 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 11:09 [PATCH] staging: wlan-ng: remove unused 'result' var Grzegorz Swirski
2014-09-20 18:16 ` Sudip Mukherjee [this message]
2014-09-20 18:35 ` Grzegorz Swirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140920181635.GA2379@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=Johannes.Stadlinger@fau.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=grzegorz@swirski.name \
--cc=himangi774@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stankus.modestas@gmail.com \
--cc=vitaly.osipov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).