* [PATCH] staging: wlan-ng: remove unused 'result' var
@ 2014-09-20 11:09 Grzegorz Swirski
2014-09-20 18:16 ` Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Grzegorz Swirski @ 2014-09-20 11:09 UTC (permalink / raw)
To: gregkh
Cc: josh, stankus.modestas, vitaly.osipov, Johannes.Stadlinger,
himangi774, grzegorz, devel, linux-kernel
Signed-off-by: Grzegorz Swirski <grzegorz@swirski.name>
---
drivers/staging/wlan-ng/prism2mib.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
index f471708..0163e06 100644
--- a/drivers/staging/wlan-ng/prism2mib.c
+++ b/drivers/staging/wlan-ng/prism2mib.c
@@ -717,8 +717,6 @@ static int prism2mib_priv(struct mibrec *mib,
{
p80211pstrd_t *pstr = (p80211pstrd_t *) data;
- int result;
-
switch (mib->did) {
case DIDmib_lnx_lnxConfigTable_lnxRSNAIE:{
hfa384x_WPAData_t wpa;
@@ -734,11 +732,10 @@ static int prism2mib_priv(struct mibrec *mib,
wpa.datalen = cpu_to_le16(pstr->len);
memcpy(wpa.data, pstr->data, pstr->len);
- result =
- hfa384x_drvr_setconfig(hw,
- HFA384x_RID_CNFWPADATA,
- (u8 *) &wpa,
- sizeof(wpa));
+ hfa384x_drvr_setconfig(hw,
+ HFA384x_RID_CNFWPADATA,
+ (u8 *) &wpa,
+ sizeof(wpa));
}
break;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: wlan-ng: remove unused 'result' var
2014-09-20 11:09 [PATCH] staging: wlan-ng: remove unused 'result' var Grzegorz Swirski
@ 2014-09-20 18:16 ` Sudip Mukherjee
2014-09-20 18:35 ` Grzegorz Swirski
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2014-09-20 18:16 UTC (permalink / raw)
To: Grzegorz Swirski
Cc: gregkh, josh, stankus.modestas, vitaly.osipov,
Johannes.Stadlinger, himangi774, devel, linux-kernel
On Sat, Sep 20, 2014 at 12:09:11PM +0100, Grzegorz Swirski wrote:
> Signed-off-by: Grzegorz Swirski <grzegorz@swirski.name>
you have not mentioned any commit log
> ---
> drivers/staging/wlan-ng/prism2mib.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index f471708..0163e06 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -717,8 +717,6 @@ static int prism2mib_priv(struct mibrec *mib,
> {
> p80211pstrd_t *pstr = (p80211pstrd_t *) data;
>
> - int result;
> -
> switch (mib->did) {
> case DIDmib_lnx_lnxConfigTable_lnxRSNAIE:{
> hfa384x_WPAData_t wpa;
> @@ -734,11 +732,10 @@ static int prism2mib_priv(struct mibrec *mib,
> wpa.datalen = cpu_to_le16(pstr->len);
> memcpy(wpa.data, pstr->data, pstr->len);
>
> - result =
> - hfa384x_drvr_setconfig(hw,
> - HFA384x_RID_CNFWPADATA,
> - (u8 *) &wpa,
> - sizeof(wpa));
> + hfa384x_drvr_setconfig(hw,
> + HFA384x_RID_CNFWPADATA,
> + (u8 *) &wpa,
if you check your patch with --strict option then you will see one warning here.
thanks
sudip
> + sizeof(wpa));
> }
> break;
> }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: wlan-ng: remove unused 'result' var
2014-09-20 18:16 ` Sudip Mukherjee
@ 2014-09-20 18:35 ` Grzegorz Swirski
0 siblings, 0 replies; 3+ messages in thread
From: Grzegorz Swirski @ 2014-09-20 18:35 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: gregkh, josh, stankus.modestas, vitaly.osipov,
Johannes.Stadlinger, himangi774, devel, linux-kernel
> you have not mentioned any commit log
Sorry. Patch against linux-next, commit
d7cf2b3139909a354a71e2885c942e21a60ea062
> > @@ -734,11 +732,10 @@ static int prism2mib_priv(struct mibrec *mib,
> > wpa.datalen = cpu_to_le16(pstr->len);
> > memcpy(wpa.data, pstr->data, pstr->len);
> >
> > - result =
> > - hfa384x_drvr_setconfig(hw,
> > - HFA384x_RID_CNFWPADATA,
> > - (u8 *) &wpa,
> > - sizeof(wpa));
> > + hfa384x_drvr_setconfig(hw,
> > + HFA384x_RID_CNFWPADATA,
> > + (u8 *) &wpa,
> if you check your patch with --strict option then you will see one warning here.
There are many styling offences in this file. I didn't want to include
unrelated changes in one patch.
Grzegorz Swirski.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-20 18:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-20 11:09 [PATCH] staging: wlan-ng: remove unused 'result' var Grzegorz Swirski
2014-09-20 18:16 ` Sudip Mukherjee
2014-09-20 18:35 ` Grzegorz Swirski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).