From: Grzegorz Swirski <grzegorz@swirski.name>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: gregkh@linuxfoundation.org, josh@joshtriplett.org,
stankus.modestas@gmail.com, vitaly.osipov@gmail.com,
Johannes.Stadlinger@fau.de, himangi774@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: wlan-ng: remove unused 'result' var
Date: Sat, 20 Sep 2014 19:35:09 +0100 [thread overview]
Message-ID: <20140920183509.GA4515@computer.home.gateway> (raw)
In-Reply-To: <20140920181635.GA2379@sudip-PC>
> you have not mentioned any commit log
Sorry. Patch against linux-next, commit
d7cf2b3139909a354a71e2885c942e21a60ea062
> > @@ -734,11 +732,10 @@ static int prism2mib_priv(struct mibrec *mib,
> > wpa.datalen = cpu_to_le16(pstr->len);
> > memcpy(wpa.data, pstr->data, pstr->len);
> >
> > - result =
> > - hfa384x_drvr_setconfig(hw,
> > - HFA384x_RID_CNFWPADATA,
> > - (u8 *) &wpa,
> > - sizeof(wpa));
> > + hfa384x_drvr_setconfig(hw,
> > + HFA384x_RID_CNFWPADATA,
> > + (u8 *) &wpa,
> if you check your patch with --strict option then you will see one warning here.
There are many styling offences in this file. I didn't want to include
unrelated changes in one patch.
Grzegorz Swirski.
prev parent reply other threads:[~2014-09-20 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 11:09 [PATCH] staging: wlan-ng: remove unused 'result' var Grzegorz Swirski
2014-09-20 18:16 ` Sudip Mukherjee
2014-09-20 18:35 ` Grzegorz Swirski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140920183509.GA4515@computer.home.gateway \
--to=grzegorz@swirski.name \
--cc=Johannes.Stadlinger@fau.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stankus.modestas@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=vitaly.osipov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).