From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH] sched/numa: kill the wrong/dead TASK_DEAD check in task_numa_fault()
Date: Sun, 21 Sep 2014 21:47:43 +0200 [thread overview]
Message-ID: <20140921194743.GA30114@redhat.com> (raw)
current->state == TASK_DEAD means that the task is doing its last
schedule(), page fault is obviously impossible at this stage.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/sched/fair.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 82088b2..0090e8c 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1804,10 +1804,6 @@ void task_numa_fault(int last_cpupid, int mem_node, int pages, int flags)
if (!p->mm)
return;
- /* Do not worry about placement if exiting */
- if (p->state == TASK_DEAD)
- return;
-
/* Allocate buffer to track faults on a per-node basis */
if (unlikely(!p->numa_faults_memory)) {
int size = sizeof(*p->numa_faults_memory) *
--
1.5.5.1
next reply other threads:[~2014-09-21 19:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 19:47 Oleg Nesterov [this message]
2014-09-22 6:54 ` [PATCH] sched/numa: kill the wrong/dead TASK_DEAD check in task_numa_fault() Mel Gorman
2014-09-22 14:42 ` Rik van Riel
2014-09-24 7:57 ` [tip:sched/core] sched/numa: Kill the wrong/ dead " tip-bot for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140921194743.GA30114@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).