From: Mel Gorman <mgorman@suse.de>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/numa: kill the wrong/dead TASK_DEAD check in task_numa_fault()
Date: Mon, 22 Sep 2014 07:54:17 +0100 [thread overview]
Message-ID: <20140922065417.GB17501@suse.de> (raw)
In-Reply-To: <20140921194743.GA30114@redhat.com>
On Sun, Sep 21, 2014 at 09:47:43PM +0200, Oleg Nesterov wrote:
> current->state == TASK_DEAD means that the task is doing its last
> schedule(), page fault is obviously impossible at this stage.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
I was going to complain that the check would protect against a spurious
allocation during fault but a task in this state should not be faulting
any more.
Acked-by: Mel Gorman <mgorman@suse.de>
Thanks.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2014-09-22 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 19:47 [PATCH] sched/numa: kill the wrong/dead TASK_DEAD check in task_numa_fault() Oleg Nesterov
2014-09-22 6:54 ` Mel Gorman [this message]
2014-09-22 14:42 ` Rik van Riel
2014-09-24 7:57 ` [tip:sched/core] sched/numa: Kill the wrong/ dead " tip-bot for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922065417.GB17501@suse.de \
--to=mgorman@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).