Re: [PATCH v4 7/9] net: pxa168_eth: allow Berlin SoCs to use the pxa168_eth driver

Antoine Tenart
2014-09-23T13:50:14Z

Arnd,

On Tue, Sep 23, 2014 at 02:40:01PM +0200, Arnd Bergmann wrote:
> On Tuesday 23 September 2014 14:15:34 Antoine Tenart wrote:
> > diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
> > index 1b4fc7c639e6..48b9466d1781 100644
> > --- a/drivers/net/ethernet/marvell/Kconfig
> > +++ b/drivers/net/ethernet/marvell/Kconfig
> > @@ -64,7 +64,7 @@ config MVPP2
> >
> > config PXA168_ETH
> > tristate "Marvell pxa168 ethernet support"
> > - depends on CPU_PXA168
> > + depends on CPU_PXA168 || ARCH_BERLIN
> > select PHYLIB
> > ---help---
> > This driver supports the pxa168 Ethernet ports.
> >
>
> Myabe you can also add '|| COMPILE_TEST' here, to allow building it

We can add this.

> on other architectures. Check if you need 'depends on OF' though.

I don't think that's needed, the driver still supports non-dt cases.
I'll check.

Antoine

--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering