From: Peter Zijlstra <peterz@infradead.org>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: "open list:X86 ARCHITECTURE..." <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read()
Date: Tue, 23 Sep 2014 16:09:38 +0200 [thread overview]
Message-ID: <20140923140938.GF3312@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJhHMCBx0_GTTHS66+2HGyJe-zcMR4d-O2x+xooNsPfvdHKd-A@mail.gmail.com>
On Tue, Sep 23, 2014 at 09:32:05AM -0400, Pranith Kumar wrote:
> On Mon, Sep 22, 2014 at 4:07 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Mon, Sep 22, 2014 at 03:53:09PM -0400, Pranith Kumar wrote:
> >> Use the much easier to read ACCESS_ONCE() which is basically the same thing as
> >> the cast to volatile.
> >>
> >> Please note the change in volatile cast: ACCESS_ONCE(v)->counter to
> >> ACCESS_ONCE(v->counter).
> >>
> >> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> >> ---
> >> arch/x86/include/asm/atomic.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > If you want to do something like so, then be consistent and do them all.
>
> Hi Peter,
>
> The changelog across all archs is as follows
>
> 18 files changed, 24 insertions(+), 24 deletions(-)
>
> Do you think it is better to send it as one patch or break up into
> patch for each arch?
I'd send it as a single patch, its small enough as is, and basically
just a 'style' update.
prev parent reply other threads:[~2014-09-23 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 19:53 [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read() Pranith Kumar
2014-09-22 20:07 ` Peter Zijlstra
2014-09-22 20:20 ` Pranith Kumar
2014-09-23 13:32 ` Pranith Kumar
2014-09-23 14:09 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923140938.GF3312@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bobby.prani@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox