From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932088AbaIWOat (ORCPT ); Tue, 23 Sep 2014 10:30:49 -0400 Received: from top.free-electrons.com ([176.31.233.9]:58293 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755446AbaIWO3m (ORCPT ); Tue, 23 Sep 2014 10:29:42 -0400 Date: Tue, 23 Sep 2014 16:29:22 +0200 From: Antoine Tenart To: Arnd Bergmann Cc: Antoine Tenart , sebastian.hesselbarth@gmail.com, alexandre.belloni@free-electrons.com, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, jszhang@marvell.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller Message-ID: <20140923142922.GE18924@kwain> References: <1411474536-22626-1-git-send-email-antoine.tenart@free-electrons.com> <1411474536-22626-4-git-send-email-antoine.tenart@free-electrons.com> <51745791.Wuu5QiQB2e@wuerfel> <20140923140113.GC18924@kwain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140923140113.GC18924@kwain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 23, 2014 at 04:01:13PM +0200, Antoine Tenart wrote: > Arnd, > > On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: > > On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: > > > +Optional properties: > > > +- port-id: should be '0','1' or '2'. > > > +- phy-addr: MDIO address of the PHY. > > > +- local-mac-address: see ethernet.txt file in the same directory. > > > + > > > > > > > I believe new bindings should not use "phy-addr" properties, but > > instead use a phy-handle property pointing to a phy device instead. > So I had a look on other Ethernet bindings. Would you agree with something like the following? eth0: ethernet@f7b90000 { ... #address-cells = <1>; #size-cells = <0>; phy-handle = <ðphy0>; ethphy0: ethernet-phy@0 { reg = <0>; }; }; Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com