Re: [PATCH] kernfs: use stack-buf for small writes.

Tejun Heo
2014-09-23T04:55:54Z

Hello, Neil.

On Tue, Sep 23, 2014 at 02:46:50PM +1000, NeilBrown wrote:
> seqfile is only safe for reads. sysfs via kernfs uses seq_read(), so there
> is only a single allocation on the first read.
>
> It doesn't really related to fixing writes, except to point out that only
> writes need to be "fixed". Reads already work.

Oh, I meant the buffer seqfile read op writes to, so it depends on the
fact that the allocation is only on the first read? That seems
extremely brittle to me, especially for an issue which tends to be
difficult to reproduce.

> Separately:
>
> > Ugh... :( If this can't be avoided at all, I'd much prefer it to be
> > something explicit - a flag marking the file as needing a persistent
> > write buffer which is allocated on open. "Small" writes on stack
> > feels way to implicit to me.
>
> How about if we add seq_getbuf() and seq_putbuf() to seqfile
> which takes a 'struct seq_file' and a size and returns the ->buf
> after making sure it is big enough.
> It also claims and releases the seqfile ->lock.
>
> Then we would be using the same buffer for reads and write.
>
> Does that sound suitable? It uses existing infrastructure and avoids having
> to identify in advance which attributes it is important for.

I'd much rather keep things direct and make it explicitly allocate r/w
buffer(s) on open and disallow seq_file operations on such files.

Thanks.

--
tejun