From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: wsa@the-dreams.de, jdelvare@suse.de, arnd@arndb.de,
dianders@chromium.org, u.kleine-koenig@pengutronix.de,
laurent.pinchart+renesas@ideasonboard.com,
boris.brezillon@free-electrons.com, maxime.coquelin@st.com,
andrew@lunn.ch, sjg@chromium.org, markus.mayer@linaro.org,
ch.naveen@samsung.com, jacob.jun.pan@linux.intel.com,
max.schwarz@online.de, mika.westerberg@linux.intel.com,
skuribay@pobox.com, Romain.Baeriswyl@abilis.com,
wenkai.du@intel.com, chiau.ee.chew@intel.com,
christian.ruppert@abilis.com, alan@linux.intel.com,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH V2] i2c-designware: Add Intel Baytrail PMIC I2C bus support
Date: Tue, 23 Sep 2014 21:00:57 +0200 [thread overview]
Message-ID: <20140923190057.GN15315@lukather> (raw)
In-Reply-To: <1411497626-7984-1-git-send-email-david.e.box@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
Hi David,
On Tue, Sep 23, 2014 at 11:40:26AM -0700, David E. Box wrote:
> This patch implements an I2C bus sharing mechanism between the host and platform
> hardware on select Intel BayTrail SoC platforms using the X-Powers AXP288 PMIC.
>
> On these platforms access to the PMIC must be shared with platform hardware. The
> hardware unit assumes full control of the I2C bus and the host must request
> access through a special semaphore. Hardware control of the bus also makes it
> necessary to disable runtime pm to avoid interfering with hardware transactions.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Sorry for stepping in like this without really knowing your platform,
but wouldn't using the hwspinlock framework make more sense than
hardcoding your own internal functions here?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-23 19:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 17:36 [PATCH] i2c-designware: Intel BayTrail PMIC I2C bus support David E. Box
2014-09-15 6:57 ` Maxime Coquelin
2014-09-15 16:55 ` David E. Box
2014-09-16 9:44 ` Mika Westerberg
2014-09-16 10:53 ` Jacob Pan
2014-09-16 10:58 ` Mika Westerberg
2014-09-17 4:01 ` Li, Aubrey
2014-09-17 11:02 ` One Thousand Gnomes
2014-09-23 18:40 ` [PATCH V2] i2c-designware: Add Intel Baytrail " David E. Box
2014-09-23 19:00 ` Maxime Ripard [this message]
2014-09-23 19:58 ` David E. Box
2014-09-25 9:47 ` Maxime Ripard
[not found] ` <20141007191420.GA25126@pathfinder>
2014-10-09 12:36 ` Maxime Ripard
2014-11-11 11:32 ` Wolfram Sang
2014-11-11 17:11 ` David E. Box
2014-11-11 11:50 ` Mika Westerberg
2014-12-02 0:09 ` [PATCH V3 0/2] i2c-designware: Baytrail bus locking driver David E. Box
2014-12-02 0:09 ` [PATCH V3 1/2] i2c-designware: Add i2c bus locking support David E. Box
2014-12-03 16:01 ` Mika Westerberg
2014-12-04 18:49 ` David E. Box
2014-12-04 7:59 ` Jarkko Nikula
2014-12-04 18:42 ` David E. Box
2015-01-13 9:48 ` Wolfram Sang
2015-01-14 18:15 ` David E. Box
2014-12-02 0:09 ` [PATCH V3 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support David E. Box
2014-12-03 16:10 ` Mika Westerberg
2014-12-04 19:11 ` David E. Box
2014-12-06 3:51 ` [PATCH V3 0/2] i2c-designware: Baytrail bus locking driver Shinya Kuribayashi
2015-01-15 9:12 ` [PATCH V4 0/2] i2c-designware: Add Intel Baytrail pmic i2c bus support David E. Box
2015-01-26 11:27 ` Wolfram Sang
2015-01-15 9:12 ` [PATCH V4 1/2] i2c-designware: Add i2c bus locking support David E. Box
2015-01-22 14:22 ` Mika Westerberg
2015-01-15 9:12 ` [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support David E. Box
2015-01-22 14:28 ` Mika Westerberg
2015-01-22 20:48 ` David E. Box
2015-01-23 9:32 ` Mika Westerberg
2015-01-23 14:18 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923190057.GN15315@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=Romain.Baeriswyl@abilis.com \
--cc=alan@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=ch.naveen@samsung.com \
--cc=chiau.ee.chew@intel.com \
--cc=christian.ruppert@abilis.com \
--cc=david.e.box@linux.intel.com \
--cc=dianders@chromium.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.mayer@linaro.org \
--cc=max.schwarz@online.de \
--cc=maxime.coquelin@st.com \
--cc=mika.westerberg@linux.intel.com \
--cc=sjg@chromium.org \
--cc=skuribay@pobox.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wenkai.du@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox