Re: [PATCH 0/5] x86/PCI: Minor size reduction by marking init code and data as such

Re: [PATCH 0/5] x86/PCI: Minor size reduction by marking init code and data as such

[Bjorn Helgaas]

[+cc x86 folks]

On Mon, Sep 22, 2014 at 02:27:48PM -0600, Bjorn Helgaas wrote:
> On Mon, Aug 25, 2014 at 11:26:34PM +0200, Mathias Krause wrote:
> > Hi Bjorn,
> > 
> > this series is a collection of patches trying to mark initialization
> > code and data of the x86 specific PCI code as such. It also contains
> > __init annotation cleanups to move them to the spot they belong to
> > according to include/linux/init.h.
> > 
> > The annotation leads to a nice reduction of run-time memory size. At
> > least two additional pages can be released after initialization which
> > are otherwise occupied by code and data no longer needed.
> > 
> > Please apply!
> > 
> > Thanks,
> > 
> > Mathias Krause (5):
> >   x86/PCI: Mark DMI tables as initialization data
> >   x86/PCI: Move __init annotation were it belongs to
> >   x86/PCI: Mark constants of pci_mmcfg_nvidia_mcp55() as __initconst
> >   x86/PCI: Constify pci_mmcfg_probes[] array
> >   x86/PCI: Mark PCI BIOS initialization code as such
> 
> All applied to pci/initdata for v3.18, thanks!

Oops, I didn't notice that you hadn't cc'd the x86 folks.

Guys, if these should go through -tip, here's my ack:

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

I don't have any other arch/x86 changes in my tree, so I don't care which
way these go.

> >  arch/x86/pci/common.c          |   20 ++++++++--------
> >  arch/x86/pci/mmconfig-shared.c |   40 ++++++++++++++++++--------------
> >  arch/x86/pci/pcbios.c          |    8 +++----
> >  3 files changed, 36 insertions(+), 32 deletions(-)
> > 
> > -- 
> > 1.7.10.4
> > 

Re: [PATCH 0/5] x86/PCI: Minor size reduction by marking init code and data as such

[Mathias Krause]

On 22 September 2014 22:34, Bjorn Helgaas <bhelgaas@google.com> wrote:
> [+cc x86 folks]
>
> On Mon, Sep 22, 2014 at 02:27:48PM -0600, Bjorn Helgaas wrote:
>> On Mon, Aug 25, 2014 at 11:26:34PM +0200, Mathias Krause wrote:
>> > Hi Bjorn,
>> >
>> > [...]
>> >
>> > Mathias Krause (5):
>> >   x86/PCI: Mark DMI tables as initialization data
>> >   x86/PCI: Move __init annotation were it belongs to
>> >   x86/PCI: Mark constants of pci_mmcfg_nvidia_mcp55() as __initconst
>> >   x86/PCI: Constify pci_mmcfg_probes[] array
>> >   x86/PCI: Mark PCI BIOS initialization code as such
>>
>> All applied to pci/initdata for v3.18, thanks!
>
> Oops, I didn't notice that you hadn't cc'd the x86 folks.

The reason for me not cc'ing the x86 maintainers, but linux-pci
instead was probably because you're listed as maintainer for these
files in the MAINTAINERS file. But, true, x86 maintainers should be
cc'ed for all patches to code below arch/x86/. Just an oversight of
mine :/

>
> Guys, if these should go through -tip, here's my ack:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> I don't have any other arch/x86 changes in my tree, so I don't care which
> way these go.


Regards,
Mathias

Re: [PATCH 0/5] x86/PCI: Minor size reduction by marking init code and data as such

[Ingo Molnar]

* Bjorn Helgaas <bhelgaas@google.com> wrote:

> [+cc x86 folks]
> 
> On Mon, Sep 22, 2014 at 02:27:48PM -0600, Bjorn Helgaas wrote:
> > On Mon, Aug 25, 2014 at 11:26:34PM +0200, Mathias Krause wrote:
> > > Hi Bjorn,
> > > 
> > > this series is a collection of patches trying to mark initialization
> > > code and data of the x86 specific PCI code as such. It also contains
> > > __init annotation cleanups to move them to the spot they belong to
> > > according to include/linux/init.h.
> > > 
> > > The annotation leads to a nice reduction of run-time memory size. At
> > > least two additional pages can be released after initialization which
> > > are otherwise occupied by code and data no longer needed.
> > > 
> > > Please apply!
> > > 
> > > Thanks,
> > > 
> > > Mathias Krause (5):
> > >   x86/PCI: Mark DMI tables as initialization data
> > >   x86/PCI: Move __init annotation were it belongs to
> > >   x86/PCI: Mark constants of pci_mmcfg_nvidia_mcp55() as __initconst
> > >   x86/PCI: Constify pci_mmcfg_probes[] array
> > >   x86/PCI: Mark PCI BIOS initialization code as such
> > 
> > All applied to pci/initdata for v3.18, thanks!
> 
> Oops, I didn't notice that you hadn't cc'd the x86 folks.
> 
> Guys, if these should go through -tip, here's my ack:
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> I don't have any other arch/x86 changes in my tree, so I don't care which
> way these go.
> 
> > >  arch/x86/pci/common.c          |   20 ++++++++--------
> > >  arch/x86/pci/mmconfig-shared.c |   40 ++++++++++++++++++--------------
> > >  arch/x86/pci/pcbios.c          |    8 +++----
> > >  3 files changed, 36 insertions(+), 32 deletions(-)

They are looking good to me in principle, and merging them via 
the PCI tree is fine with me as well:

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo