From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Grant Likely <grant.likely@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib: string.c: Added a funktion function strzcpy
Date: Wed, 24 Sep 2014 10:52:06 +0300 [thread overview]
Message-ID: <20140924075206.GC5865@mwanda> (raw)
In-Reply-To: <20140924011753.GG28253@tassilo.jf.intel.com>
On Tue, Sep 23, 2014 at 06:17:53PM -0700, Andi Kleen wrote:
> On Wed, Sep 24, 2014 at 12:13:36AM +0200, Rickard Strandqvist wrote:
> > Added a function strzcpy which works the same as strncpy,
> > but guaranteed to produce the trailing null character.
>
> Do we really need the bizarre strncpy padding semantics for anything?
> Why not just use strlcpy?
We do need the padding in many places to prevent information leaks.
So we end up open coding the last NUL after so many of the strncpy()
calls. And we're adding more NUL terminators all over the place now
just to make the code easier to audit.
regards,
dan carpenter
next prev parent reply other threads:[~2014-09-24 7:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 22:13 [PATCH] lib: string.c: Added a funktion function strzcpy Rickard Strandqvist
2014-09-23 22:13 ` Rickard Strandqvist
2014-09-23 22:40 ` Andrew Morton
2014-09-24 1:17 ` Andi Kleen
2014-09-24 7:52 ` Dan Carpenter [this message]
2014-09-24 14:14 ` Lennart Sorensen
2014-09-24 14:35 ` Andi Kleen
[not found] ` <CAFo99gZUfFUB9xX0GYW=hJMNouiU-M9apZ8KtPg9MW3x7gxZcg@mail.gmail.com>
2014-09-24 14:58 ` Andi Kleen
2014-09-24 15:41 ` Dan Carpenter
2014-09-24 20:51 ` Rickard Strandqvist
2014-09-24 21:26 ` Andrew Morton
2014-09-24 21:49 ` Rickard Strandqvist
2014-09-24 22:55 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924075206.GC5865@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox