From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbaIXJhM (ORCPT ); Wed, 24 Sep 2014 05:37:12 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:44542 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbaIXJhI (ORCPT ); Wed, 24 Sep 2014 05:37:08 -0400 Date: Wed, 24 Sep 2014 12:36:48 +0300 From: Dan Carpenter To: Daeseok Youn Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: dgap: adds missing iounmap for re_map_port in dgap_release_remap() Message-ID: <20140924093648.GA5811@mwanda> References: <20140923002208.GA20768@devel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140923002208.GA20768@devel> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 23, 2014 at 09:22:08AM +0900, Daeseok Youn wrote: > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgap/dgap.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c > index 779d144..637ea8a 100644 > --- a/drivers/staging/dgap/dgap.c > +++ b/drivers/staging/dgap/dgap.c > @@ -1026,6 +1026,7 @@ static void dgap_release_remap(struct board_t *brd) > release_mem_region(brd->membase, 0x200000); > release_mem_region(brd->membase + PCI_IO_OFFSET, 0x200000); > iounmap(brd->re_map_membase); > + iounmap(brd->re_map_port); I don't think it matters, but at least aesthetically it would be better to unmap first and then release the regions. (You can do this in a different patch). regards, dan carpenter