public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Michal Sojka <sojka@merica.cz>,
	linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
	Bryan Wu <cooloney@gmail.com>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	linux-kernel@vger.kernel.org, michal.vokac@comap.cz
Subject: Re: [PATCH v6 0/4] LED triggers for USB host and device
Date: Wed, 24 Sep 2014 23:41:55 +0200	[thread overview]
Message-ID: <20140924214155.GA30689@kroah.com> (raw)
In-Reply-To: <20140924205936.GC17997@saruman>

On Wed, Sep 24, 2014 at 03:59:36PM -0500, Felipe Balbi wrote:
> On Wed, Sep 24, 2014 at 10:43:17PM +0200, Michal Sojka wrote:
> > This adds LED triggers for USB host and device. First two patches
> > refactor UDC drivers as requested by Felipe Balbi, the next renames a
> > file and the last is the actual implementation of the LED triggers.
> > 
> > Changes from v5:
> > - Refactoring of USB gadget completion split into two patches (Filipe
> >   Balbi)
> > - Removed check for non-NULL req->completion (Filipe Balbi)
> > 
> > Changes from v4:
> > - Added performance numbers to the commit message of the last patch
> >   (greg k-h).
> > - Replaced BUG_ON with pr_err (Alan Stern, greg k-h).
> > - Used proper coding style for switch statement (greg k-h).
> > - Added comment about NULL argument (greg k-h).
> > - EXPORT_SYMBOL changed to EXPORT_SYMBOL_GPL (greg k-h).
> > - Both triggers are now registerd even if host or gagdet subsystem
> >   is not enabled (Bryan Wu, greg k-h).
> > 
> > Changes from v3:
> > - usb_gadget_giveback_request() moved outside of CONFIG_HAS_DMA
> >   conditioned block.
> > - Added kernel-doc for usb_gadget_giveback_request() (Felipe Balbi).
> > - Removed outdated comment (Alan Stern).
> > - req->complete == NULL is now a bug. Previously, this was ignored
> >   (Alan Stern).
> > - File rename moved to a separate commit (greg k-h).
> > 
> > Changes from v2:
> > - Host/gadget triggers merged to a single file in usb/common/ (Felipe
> >   Balbi).
> > - UDC drivers refactored so that LED trigger works for all of them.
> > 
> > Changes from v1:
> > - Moved from drivers/leds/ to drivers/usb/.
> > - Improved Kconfig help.
> > - Linked with other modules rather than being standalone modules.
> > 
> > Michal Sojka (4):
> >   usb: gadget: Introduce usb_gadget_giveback_request()
> >   usb: gadget: Refactor request completion
> >   usb: Rename usb-common.c
> >   usb: Add LED triggers for USB activity
> 
> Greg, how do you want to handle this one as it touched both host and
> gadget ? I could wait until you apply this series to your usb-next and
> based my pull request on that. That'll work as long as it doesn't take
> too long for this to be merged.

I can just take this now, for 3.18-rc1, you've already sent me your
patches for that release, so there shouldn't be any conflicts, right?

thanks,

greg k-h

  reply	other threads:[~2014-09-24 21:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  7:21 [PATCH v5 0/3] LED triggers for USB host and device Michal Sojka
2014-09-17  7:21 ` [PATCH v5 1/3] usb: gadget: Refactor request completion Michal Sojka
2014-09-17 15:28   ` Felipe Balbi
2014-09-23  8:09     ` Michal Sojka
2014-09-24 14:48       ` Felipe Balbi
2014-09-24 15:08       ` Alan Stern
2014-09-24 20:43         ` [PATCH v6 0/4] LED triggers for USB host and device Michal Sojka
2014-09-24 20:43           ` [PATCH v6 1/4] usb: gadget: Introduce usb_gadget_giveback_request() Michal Sojka
2014-09-24 21:00             ` Felipe Balbi
2014-09-24 20:43           ` [PATCH v6 2/4] usb: gadget: Refactor request completion Michal Sojka
2014-09-24 23:14             ` Felipe Balbi
2014-09-29  8:50             ` Robert Baldyga
2014-09-29  9:13               ` Michal Sojka
2014-09-29 14:05               ` Felipe Balbi
2014-09-24 20:43           ` [PATCH v6 3/4] usb: Rename usb-common.c Michal Sojka
2014-09-24 23:15             ` Felipe Balbi
2014-09-25 15:03             ` Greg Kroah-Hartman
2014-09-25 15:48               ` project wide: git config entry for [diff] renames=true Joe Perches
2014-09-25 18:00                 ` Jeff King
2014-09-25 18:06                   ` Joe Perches
2014-09-25 18:43                     ` Junio C Hamano
2014-09-25 18:53                   ` Junio C Hamano
2014-09-24 20:43           ` [PATCH v6 4/4] usb: Add LED triggers for USB activity Michal Sojka
2014-09-24 20:56             ` Felipe Balbi
2014-09-24 20:59           ` [PATCH v6 0/4] LED triggers for USB host and device Felipe Balbi
2014-09-24 21:41             ` Greg Kroah-Hartman [this message]
2014-09-24 22:18               ` Felipe Balbi
2014-09-24 23:15                 ` Felipe Balbi
2014-09-25 10:36                   ` Greg Kroah-Hartman
2014-09-25 13:56                     ` Felipe Balbi
2014-09-25 14:56                       ` Greg Kroah-Hartman
2014-09-17  7:21 ` [PATCH v5 2/3] usb: Rename usb-common.c Michal Sojka
2014-09-17  7:21 ` [PATCH v5 3/3] usb: Add LED triggers for USB activity Michal Sojka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140924214155.GA30689@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@ti.com \
    --cc=cooloney@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.vokac@comap.cz \
    --cc=sojka@merica.cz \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox