From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Elshad Mustafayev <elshadimo@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver: staging: android: binder.c: Fixed line over 80 characters warning.
Date: Thu, 25 Sep 2014 00:02:47 +0200 [thread overview]
Message-ID: <20140924220247.GB31890@kroah.com> (raw)
In-Reply-To: <20140923231209.GA3785@emustafa>
On Tue, Sep 23, 2014 at 07:12:09PM -0400, Elshad Mustafayev wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Elshad Mustafayev <elshadimo@gmail.com>
> ---
> drivers/staging/android/binder.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index c69c40d..71424bf 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -664,8 +664,9 @@ static struct binder_buffer *binder_alloc_buf(struct binder_proc *proc,
> ALIGN(offsets_size, sizeof(void *));
>
> if (size < data_size || size < offsets_size) {
> - binder_user_error("%d: got transaction with invalid size %zd-%zd\n",
> - proc->pid, data_size, offsets_size);
> + binder_user_error(
> + "%d: got transaction with invalid size %zd-%zd\n",
> + proc->pid, data_size, offsets_size);
Nope, original code is just fine, checkpatch is giving you a
false-warning here.
greg k-h
prev parent reply other threads:[~2014-09-24 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 23:12 [PATCH] driver: staging: android: binder.c: Fixed line over 80 characters warning Elshad Mustafayev
2014-09-24 22:02 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924220247.GB31890@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=elshadimo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox