From: Andi Kleen <ak@linux.intel.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Grant Likely <grant.likely@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lib: string.c: Added a funktion function strzcpy
Date: Wed, 24 Sep 2014 15:55:08 -0700 [thread overview]
Message-ID: <20140924225508.GO28253@tassilo.jf.intel.com> (raw)
In-Reply-To: <CAFo99gY8PAxTAourZpRDBosX9qWiOq_fS1xOHPAzujOwEhfCFw@mail.gmail.com>
> Thought that I was still fairly clear, or that I just assumed that
> everyone was more or less familiar with the problems between strncpy
> strlcpy etc.
> Did not think all that should be includerad in chang log.
I don't think you need to write a novel.
So the basic issue is that you're not sure if you can replace
strncpy with strlcpy (due to not knowing what the padding
requirements are), but you still want to make sure everything
is zero terminated.
That should have been in the changelog.
-Andi
prev parent reply other threads:[~2014-09-24 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 22:13 [PATCH] lib: string.c: Added a funktion function strzcpy Rickard Strandqvist
2014-09-23 22:13 ` Rickard Strandqvist
2014-09-23 22:40 ` Andrew Morton
2014-09-24 1:17 ` Andi Kleen
2014-09-24 7:52 ` Dan Carpenter
2014-09-24 14:14 ` Lennart Sorensen
2014-09-24 14:35 ` Andi Kleen
[not found] ` <CAFo99gZUfFUB9xX0GYW=hJMNouiU-M9apZ8KtPg9MW3x7gxZcg@mail.gmail.com>
2014-09-24 14:58 ` Andi Kleen
2014-09-24 15:41 ` Dan Carpenter
2014-09-24 20:51 ` Rickard Strandqvist
2014-09-24 21:26 ` Andrew Morton
2014-09-24 21:49 ` Rickard Strandqvist
2014-09-24 22:55 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924225508.GO28253@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox