From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753937AbaIYRwj (ORCPT ); Thu, 25 Sep 2014 13:52:39 -0400 Received: from mga14.intel.com ([192.55.52.115]:22034 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753486AbaIYRwh (ORCPT ); Thu, 25 Sep 2014 13:52:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="391625839" Date: Thu, 25 Sep 2014 10:52:34 -0700 From: Jacob Pan To: Maxime Ripard Cc: IIO , LKML , DEVICE TREE , Lee Jones , Carlo Caione , Srinivas Pandruvada , Aaron Lu , Alan Cox , Jean Delvare , Samuel Ortiz , Liam Girdwood , Mark Brown , Grant Likely , Greg Kroah-Hartman , Rob Herring , Lars-Peter Clausen , Hartmut Knaack , Fugang Duan , Arnd Bergmann , Zubair Lutfullah , Sebastian Reichel , Johannes Thumshirn , Philippe Reynes , Angelo Compagnucci , Doug Anderson , Ramakrishna Pallala , Peter Meerwald , Rafael Wysocki Subject: Re: [PATCH v5 1/2] mfd/axp20x: extend axp20x to support axp288 pmic Message-ID: <20140925105234.65c826c9@jacob-VirtualBox> In-Reply-To: <20140925100220.GA15315@lukather> References: <1411518027-19907-1-git-send-email-jacob.jun.pan@linux.intel.com> <1411518027-19907-2-git-send-email-jacob.jun.pan@linux.intel.com> <20140925100220.GA15315@lukather> Organization: OTC X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Sep 2014 12:02:20 +0200 Maxime Ripard wrote: > It's fine otherwise. Once fixed, you can add my > > Reviewed-by: Maxime Ripard thanks for the review. will fix as suggested except rewriting flow in axp20x_match_device() as suggested by Lee Jones.