From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Sojka <sojka@merica.cz>
Cc: linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
Bryan Wu <cooloney@gmail.com>, Felipe Balbi <balbi@ti.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
linux-kernel@vger.kernel.org, michal.vokac@comap.cz
Subject: Re: [PATCH v6 3/4] usb: Rename usb-common.c
Date: Thu, 25 Sep 2014 17:03:53 +0200 [thread overview]
Message-ID: <20140925150353.GA15325@kroah.com> (raw)
In-Reply-To: <1411591401-5874-4-git-send-email-sojka@merica.cz>
On Wed, Sep 24, 2014 at 10:43:20PM +0200, Michal Sojka wrote:
> In the next commit, we will want the usb-common module to be composed of
> two object files. Since Kbuild cannot "append" another object to an
> existing one, we need to rename usb-common.c to something
> else (common.c) and create usb-common.o by linking the wanted objects
> together. Currently, usb-common.o comprises only common.o.
>
> Signed-off-by: Michal Sojka <sojka@merica.cz>
> Acked-by: Felipe Balbi <balbi@ti.com>
> Tested-by: Felipe Balbi <balbi@ti.com>
> ---
> drivers/usb/common/Makefile | 4 +-
> drivers/usb/common/common.c | 144 ++++++++++++++++++++++++++++++++++++++++
> drivers/usb/common/usb-common.c | 144 ----------------------------------------
> 3 files changed, 147 insertions(+), 145 deletions(-)
> create mode 100644 drivers/usb/common/common.c
> delete mode 100644 drivers/usb/common/usb-common.c
In the future, please generate a git "move" diff, which makes it easier
to review, and prove that nothing really changed. It also helps if the
file is a bit different from what you diffed against, which in my case,
was true.
thanks,
greg k-h
next prev parent reply other threads:[~2014-09-25 15:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 7:21 [PATCH v5 0/3] LED triggers for USB host and device Michal Sojka
2014-09-17 7:21 ` [PATCH v5 1/3] usb: gadget: Refactor request completion Michal Sojka
2014-09-17 15:28 ` Felipe Balbi
2014-09-23 8:09 ` Michal Sojka
2014-09-24 14:48 ` Felipe Balbi
2014-09-24 15:08 ` Alan Stern
2014-09-24 20:43 ` [PATCH v6 0/4] LED triggers for USB host and device Michal Sojka
2014-09-24 20:43 ` [PATCH v6 1/4] usb: gadget: Introduce usb_gadget_giveback_request() Michal Sojka
2014-09-24 21:00 ` Felipe Balbi
2014-09-24 20:43 ` [PATCH v6 2/4] usb: gadget: Refactor request completion Michal Sojka
2014-09-24 23:14 ` Felipe Balbi
2014-09-29 8:50 ` Robert Baldyga
2014-09-29 9:13 ` Michal Sojka
2014-09-29 14:05 ` Felipe Balbi
2014-09-24 20:43 ` [PATCH v6 3/4] usb: Rename usb-common.c Michal Sojka
2014-09-24 23:15 ` Felipe Balbi
2014-09-25 15:03 ` Greg Kroah-Hartman [this message]
2014-09-25 15:48 ` project wide: git config entry for [diff] renames=true Joe Perches
2014-09-25 18:00 ` Jeff King
2014-09-25 18:06 ` Joe Perches
2014-09-25 18:43 ` Junio C Hamano
2014-09-25 18:53 ` Junio C Hamano
2014-09-24 20:43 ` [PATCH v6 4/4] usb: Add LED triggers for USB activity Michal Sojka
2014-09-24 20:56 ` Felipe Balbi
2014-09-24 20:59 ` [PATCH v6 0/4] LED triggers for USB host and device Felipe Balbi
2014-09-24 21:41 ` Greg Kroah-Hartman
2014-09-24 22:18 ` Felipe Balbi
2014-09-24 23:15 ` Felipe Balbi
2014-09-25 10:36 ` Greg Kroah-Hartman
2014-09-25 13:56 ` Felipe Balbi
2014-09-25 14:56 ` Greg Kroah-Hartman
2014-09-17 7:21 ` [PATCH v5 2/3] usb: Rename usb-common.c Michal Sojka
2014-09-17 7:21 ` [PATCH v5 3/3] usb: Add LED triggers for USB activity Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925150353.GA15325@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=cooloney@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.vokac@comap.cz \
--cc=sojka@merica.cz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox