From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753603AbaIYPEw (ORCPT ); Thu, 25 Sep 2014 11:04:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60874 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752501AbaIYPEu (ORCPT ); Thu, 25 Sep 2014 11:04:50 -0400 Date: Thu, 25 Sep 2014 17:03:53 +0200 From: Greg Kroah-Hartman To: Michal Sojka Cc: linux-usb@vger.kernel.org, Alan Stern , Bryan Wu , Felipe Balbi , Linux LED Subsystem , linux-kernel@vger.kernel.org, michal.vokac@comap.cz Subject: Re: [PATCH v6 3/4] usb: Rename usb-common.c Message-ID: <20140925150353.GA15325@kroah.com> References: <1411591401-5874-1-git-send-email-sojka@merica.cz> <1411591401-5874-4-git-send-email-sojka@merica.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411591401-5874-4-git-send-email-sojka@merica.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 24, 2014 at 10:43:20PM +0200, Michal Sojka wrote: > In the next commit, we will want the usb-common module to be composed of > two object files. Since Kbuild cannot "append" another object to an > existing one, we need to rename usb-common.c to something > else (common.c) and create usb-common.o by linking the wanted objects > together. Currently, usb-common.o comprises only common.o. > > Signed-off-by: Michal Sojka > Acked-by: Felipe Balbi > Tested-by: Felipe Balbi > --- > drivers/usb/common/Makefile | 4 +- > drivers/usb/common/common.c | 144 ++++++++++++++++++++++++++++++++++++++++ > drivers/usb/common/usb-common.c | 144 ---------------------------------------- > 3 files changed, 147 insertions(+), 145 deletions(-) > create mode 100644 drivers/usb/common/common.c > delete mode 100644 drivers/usb/common/usb-common.c In the future, please generate a git "move" diff, which makes it easier to review, and prove that nothing really changed. It also helps if the file is a bit different from what you diffed against, which in my case, was true. thanks, greg k-h