From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753398AbaIYPKe (ORCPT ); Thu, 25 Sep 2014 11:10:34 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:44256 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbaIYPKc (ORCPT ); Thu, 25 Sep 2014 11:10:32 -0400 X-Google-Original-Sender: Date: Thu, 25 Sep 2014 17:07:57 +0200 From: Johan Hovold To: Octavian Purdila Cc: sameo@linux.intel.com, lee.jones@linaro.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, johan@kernel.org Subject: Re: [PATCH v3 3/3] mfd: viperboard: remove unused platform_device Message-ID: <20140925150757.GH32124@localhost> References: <1411656197-26517-1-git-send-email-octavian.purdila@intel.com> <1411656197-26517-4-git-send-email-octavian.purdila@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1411656197-26517-4-git-send-email-octavian.purdila@intel.com> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 25, 2014 at 05:43:17PM +0300, Octavian Purdila wrote: Where's the commit message body? > Signed-off-by: Octavian Purdila > --- > drivers/mfd/viperboard.c | 1 - > include/linux/mfd/viperboard.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/mfd/viperboard.c b/drivers/mfd/viperboard.c > index 57fac1d..1e7c316 100644 > --- a/drivers/mfd/viperboard.c > +++ b/drivers/mfd/viperboard.c > @@ -74,7 +74,6 @@ static int vprbrd_probe(struct usb_interface *interface, > > /* save our data pointer in this interface device */ > usb_set_intfdata(interface, vb); > - dev_set_drvdata(&vb->pdev.dev, vb); This looks ok, as the subdrivers are accessing the driver data via the usb-interface (their parent) device. You verified that too, right? > > /* get version information, major first, minor then */ > pipe = usb_rcvctrlpipe(vb->usb_dev, 0); > diff --git a/include/linux/mfd/viperboard.h b/include/linux/mfd/viperboard.h > index af928d0..afc14ed 100644 > --- a/include/linux/mfd/viperboard.h > +++ b/include/linux/mfd/viperboard.h > @@ -104,7 +104,6 @@ struct vprbrd { > struct usb_device *usb_dev; /* the usb device for this device */ > struct mutex lock; > u8 *buf; > - struct platform_device pdev; > }; > > #endif /* __MFD_VIPERBOARD_H__ */ Still feels like the kind of clean up that should have a Tested-by. Johan