From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753820AbaIZCZq (ORCPT ); Thu, 25 Sep 2014 22:25:46 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:36437 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753225AbaIZCZp (ORCPT ); Thu, 25 Sep 2014 22:25:45 -0400 Date: Thu, 25 Sep 2014 19:25:20 -0700 From: Sukadev Bhattiprolu To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , ak@linux.intel.com, peterz@infradead.org, eranian@google.com, Paul Mackerras , dev@codyps.com, Michael Ellerman , Anshuman Khandual , hbabu@us.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 01/10] tools/perf: support parsing parameterized events Message-ID: <20140926022520.GA8997@us.ibm.com> References: <1411586844-21381-1-git-send-email-sukadev@linux.vnet.ibm.com> <1411586844-21381-2-git-send-email-sukadev@linux.vnet.ibm.com> <20140925085858.GA20915@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140925085858.GA20915@krava.brq.redhat.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14092602-9332-0000-0000-0000022485BA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Olsa [jolsa@redhat.com] wrote: | On Wed, Sep 24, 2014 at 12:27:15PM -0700, Sukadev Bhattiprolu wrote: | > From: Cody P Schafer | > | > Enable event specification like: | > | > pmu/event_name,param1=0x1,param2=0x4/ | > | > Assuming that | > | > /sys/bus/event_source/devices/pmu/events/event_name | > | > Contains something like | > | > param2=foo,bar=1,param1=baz | | hum, so what happened to the '?' ... AFAIU from out last discussion, | you wanted to mark terms which are mandatory and user must provide | values for them.. and I thought the decision was to have following | alias record: | | $ cat /sys/bus/event_source/devices/pmu/events/event_name | param2=?,bar=1,param1=? | | while perf would scream if any of param1/2 wasnt filled like for: | pmu/event_name,param1=0x1/ Sorry, I meant to make perf list consistent with sysfs. Consider these two sysfs entries: $ cat HPM_0THRD_NON_IDLE_CCYC__PHYS_CORE domain=0x2,offset=0xe0,starting_index=core,lpar=0x0 $ cat HPM_0THRD_NON_IDLE_CCYC__VCPU_HOME_CORE domain=0x3,offset=0xe0,starting_index=vcpu,lpar=sibling_guest_id In the first one, starting_index refers to a 'core' while in the second it refers to a vcpu. This serves as a "hint" for the parameter's meaning. By replacing both with 'starting_index=?' we lose that hint. Should we fix both sysfs and 'perf list' to say starting_index=?core Sukadev