Re: [PATCH 1/4] toshiba_acpi: Rename hci_raw to tci_raw

Darren Hart
2014-09-26T03:01:35Z

On Tue, Sep 23, 2014 at 06:24:25PM -0600, Azael Avalos wrote:
> The function name hci_raw was used before to reflect
> a raw (read/write) call to the Toshiba's Hardware
> Configuration Interface (HCI), however, since the
> introduction of the System Configuration Interface
> (SCI), that "name" no longer applies.
>
> This patch changes the name of that function to
> tci_raw (for Toshiba Configuration Interface), and
> change the comments about it.

I'm not following the motivation for this change. The HCI clearly still exists,
at least on the platforms this driver was written to support. When/Where was the
"SCI" "introduced" in a way that requires a change here? Was this a change by
Toshiba you are refering to?

>
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
> ---
> drivers/platform/x86/toshiba_acpi.c | 40 ++++++++++++++++++-------------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
> index edd8f3d..b7030dc 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -71,7 +71,7 @@ MODULE_LICENSE("GPL");
> /* Toshiba ACPI method paths */
> #define METHOD_VIDEO_OUT "\\_SB_.VALX.DSSX"
>
> -/* Toshiba HCI interface definitions
> +/* Toshiba configuration interface definitions
> *
> * HCI is Toshiba's "Hardware Control Interface" which is supposed to

I'm not sure this patch is appropriate/necessary, but if so, you missed a spot
here :)

--
Darren Hart
Intel Open Source Technology Center