From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754087AbaIZIoM (ORCPT ); Fri, 26 Sep 2014 04:44:12 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:43621 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753017AbaIZIoK (ORCPT ); Fri, 26 Sep 2014 04:44:10 -0400 Date: Fri, 26 Sep 2014 09:44:03 +0100 From: Russell King - ARM Linux To: "Li.Xiubo@freescale.com" Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs Message-ID: <20140926084403.GK5182@n2100.arm.linux.org.uk> References: <1409546541-4129-1-git-send-email-Li.Xiubo@freescale.com> <9dc024498c904d48b3a25430f8d31f29@BY2PR0301MB0613.namprd03.prod.outlook.com> <20140926082054.GI5182@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 26, 2014 at 08:39:04AM +0000, Li.Xiubo@freescale.com wrote: > [...] > > On Fri, Sep 26, 2014 at 05:30:40AM +0000, Li.Xiubo@freescale.com wrote: > > > Hi Russell, > > > > > > I'd like to know the status of this patch. > > > > > > Our Platforms depend on it. > > > > I'm not applying it. This option should not be exposed for general > > use. The usage pattern is clear from the existing users - propose > > an alternative default value for your platform rather than making it > > a user visible tweakable option. > > > > Okay. > > Something like : > ++++++++++ > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 1ad6fb6..5729a2c 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1802,7 +1802,7 @@ source "mm/Kconfig" > config FORCE_MAX_ZONEORDER > int "Maximum zone order" if ARCH_SHMOBILE > range 11 64 if ARCH_SHMOBILE > - default "12" if SOC_AM33XX > + default "12" if SOC_AM33XX || SOC_LS1021A > default "9" if SA1111 > default "11" > help > ---------- > > Is okay ? It's much better than exposing the option, but I'd like this patch to appear as a properly submitted change (including a change log which provides the reason why this is necessary.) Thanks. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.