From: Vinod Koul <vinod.koul@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Roman Gushchin <klamm@yandex-team.ru>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net_dma: fix memory leak in dma_pin_iocvec_pages
Date: Sun, 28 Sep 2014 20:55:40 +0530 [thread overview]
Message-ID: <20140928152540.GE1638@intel.com> (raw)
In-Reply-To: <CAPcyv4hfo6PqFfoCfB3esAn7qQ0Z+oA=35e+re8v7_Y7C5_UCw@mail.gmail.com>
On Sun, Sep 28, 2014 at 08:36:44AM -0700, Dan Williams wrote:
> On Thu, Sep 25, 2014 at 9:16 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Tue, Sep 23, 2014 at 11:27:06PM -0700, Dan Williams wrote:
> >> On Tue, Sep 23, 2014 at 9:57 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> >> > On Wed, Sep 03, 2014 at 01:28:59PM +0400, Roman Gushchin wrote:
> >> >> dma_pin_iovec_pages() calls get_user_pages() for each iovec. If
> >> >> get_user_pages() returns a number smaller than the requested number,
> >> >> dma_pin_iovec_pages() calls dma_unpin_iovec_pages(). It releases
> >> >> previously allocated iovecs, but pages pinned by last get_user_pages()
> >> >> call remain unreleased.
> >> >> Fix this by calling put_page() for each such page.
> >> >>
> >> > Applied, thanks
> >>
> >> Vinod, I have a patch in my queue that completely removes the remnants
> >> of NET_DMA. It's been deprecated for more than a few cycles now
> >> without any reports to reinstate it. Time to push the final removal
> >> patch. I'll rebase it on top of this so it doesn't collide.
> >
> > Okay, thanks for update. If you wnat I can remove it, so you don't need to
> > rebase.
> >
>
> Yes, please drop it. I'm sending the full removal to Linus. I added
> Roman to the Reported-by and cc'd stable.
Done, i have pushed the updated tree.
--
~Vinod
prev parent reply other threads:[~2014-09-28 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 9:28 [PATCH] net_dma: fix memory leak in dma_pin_iocvec_pages Roman Gushchin
2014-09-19 12:04 ` Roman Gushchin
2014-09-24 4:57 ` Vinod Koul
2014-09-24 6:27 ` Dan Williams
2014-09-25 16:16 ` Vinod Koul
2014-09-28 15:36 ` Dan Williams
2014-09-28 15:25 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928152540.GE1638@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=klamm@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).