Re: [PATCH] ASoC:kirkwood: Don't raise an error when no DAI format

Russell King - ARM Linux
2014-09-28T15:12:19Z

On Sun, Sep 28, 2014 at 04:19:27PM +0200, Jean-Francois Moine wrote:
> The two DAIs of the kirkwood controller have a unique PCM format.
>
> The simple-card sets the audio hardware definitions of all CPU DAIs.
> The PCM format is defined only when it is present in the DT.
>
> This patch prevents the controller to raise an error when
> the DT audio card definition by the simple card contains the PCM
> format of one CPU DAI only.

I think this is a silly idea - why should every driver have additional code
to detect when it's called to do thing. Why doesn't the simple card code
always pass the required format?

Looking at other drivers, no one else does this; they all appear to require
the proper format to be specified.

What some drivers do (eg, omap-mcbsp.c) is to block set_fmt when the
DAI is already in use - setting a flag "configured" in hw_params, and
clearing it in shutdown. Maybe following this will solve your problem.

In any case, random drivers doing stuff differently without reason is
really not a good idea.

--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.